Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncState can be used across different service providers #4966

Merged
merged 4 commits into from
Feb 29, 2024
Merged

AsyncState can be used across different service providers #4966

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54f318f
AsyncState can be used across different service providers
Feb 23, 2024
d7aeb24
Fixed tests
Feb 23, 2024
8b286dd
Disable test parallelization and suppress warning.
Feb 23, 2024
2ed5a8b
Added assertion to AsyncStateCanBeUsedInDifferentServiceProviders() t…
Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Libraries/Microsoft.Extensions.AsyncState/AsyncState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ internal static void EnsureCount(List<object?> features, int count)
}
}

#pragma warning disable CA1822
mobratil marked this conversation as resolved.
Show resolved Hide resolved
internal int ContextCount => Volatile.Read(ref _contextCount);
#pragma warning restore CA1822

private sealed class AsyncStateHolder
{
Expand Down
3 changes: 3 additions & 0 deletions test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
using Xunit;

Check failure on line 1 in test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs

View check run for this annotation

Azure Pipelines / extensions-ci (Correctness WarningsCheck)

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs#L1 

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs(1,1): error IDE0073: (NETCORE_ENGINEERING_TELEMETRY=Build) A source file is missing a required header. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0073)

Check failure on line 1 in test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs

View check run for this annotation

Azure Pipelines / extensions-ci (Correctness WarningsCheck)

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs#L1 

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs(1,1): error IDE0073: (NETCORE_ENGINEERING_TELEMETRY=Build) A source file is missing a required header. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0073)

Check failure on line 1 in test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs

View check run for this annotation

Azure Pipelines / extensions-ci

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs#L1 

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs(1,1): error IDE0073: (NETCORE_ENGINEERING_TELEMETRY=Build) A source file is missing a required header. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0073)

Check failure on line 1 in test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs

View check run for this annotation

Azure Pipelines / extensions-ci

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs#L1 

test/Libraries/Microsoft.Extensions.AsyncState.Tests/AssemblyInfo.cs(1,1): error IDE0073: (NETCORE_ENGINEERING_TELEMETRY=Build) A source file is missing a required header. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0073)
mobratil marked this conversation as resolved.
Show resolved Hide resolved

[assembly: CollectionBehavior(DisableTestParallelization = true)]
Loading