-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move unified build sdk validation to a test project #19090
Conversation
…rojectValidation
…move it into the test later
.../content/test/Microsoft.DotNet.UnifiedBuild.Tests/Microsoft.DotNet.UnifiedBuild.Tests.csproj
Outdated
Show resolved
Hide resolved
…rojectValidation
- Move Directory.Build.props to build UB tests with arcade - Use msbuild task to run tests rather than exec - Update old condition for building UB tests
…rojectValidation
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@@ -15,7 +15,7 @@ | |||
UnpackTarballs; | |||
BuildUnifiedBuildTasks; | |||
BuildMSBuildSdkResolver; | |||
BuildSdkArchiveDiff; | |||
BuildUnifiedBuildValidationTests; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is test project it doesn't belong here anymore. That can be updated in a follow-up though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it automatically get restored by arcade as a test project? Or can we assume it will never be run in an offline build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will get restored same as the build.proj and the repo-projects/ .proj files. But as mentioned, it might be better to do that in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like building this before the sdk version is determined, and the runtime config values aren't being set, so it'll need to be done here.
.../content/test/Microsoft.DotNet.UnifiedBuild.Tests/Microsoft.DotNet.UnifiedBuild.Tests.csproj
Outdated
Show resolved
Hide resolved
.../content/test/Microsoft.DotNet.UnifiedBuild.Tests/Microsoft.DotNet.UnifiedBuild.Tests.csproj
Outdated
Show resolved
Hide resolved
- Remove reference to Logging package - Update FileGlobbing Version to 8.0 - Move Validation target to installer repo-projects project - Set VSTestUseMSBuildOutput=true in test project file
It looks like we don't set |
…rojectValidation
src/SourceBuild/content/test/Microsoft.DotNet.UnifiedBuild.Tests/NuGet.config
Outdated
Show resolved
Hide resolved
.../content/test/Microsoft.DotNet.UnifiedBuild.Tests/Microsoft.DotNet.UnifiedBuild.Tests.csproj
Outdated
Show resolved
Hide resolved
- Remove setting VSTestUseMSBuildOutput - Set DotnetHostPath in runsettings - Silence output if using msbuild logger - Remove nuget config - Don't publish self-contained
@jtschuster - Friendly reminder to do a Edit: Looking through this commit history, I thought it might've just been merged, but I could totally be wrong! |
@ellahathaway Oops, looks like it was merged without a squash. Thanks for the notice, squash and merge is the only option in runtime so I've gotten used to doing the default. |
using Xunit; | ||
using Xunit.Abstractions; | ||
|
||
namespace Microsoft.DotNet.SourceBuild.SmokeTests; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these namespaces should be updated to match the project name.
Instead of the msbuild tasks, use a test project similar to the source-build sdk smoke tests to test the files present in the archive and their versions. This began with a copy of the source build smoke tests that were adapted to unified build. The diff for the shared files is below.
I'm investigating why the baselines aren't working in CI, but this is ready to review otherwise.
Diff from SourceBuild smoke tests