Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move unified build sdk validation to a test project #19090
Move unified build sdk validation to a test project #19090
Changes from 51 commits
ee1dce8
0836474
158c2aa
1991c7b
b076829
b1dfb7a
cdbd8e5
46cc050
949a304
db4d2d2
47053c4
a783e3b
7180f58
736b6f4
4efaf69
d85e153
43e52e8
5c57672
3a96da9
a82bdc9
2a70b8a
9faaceb
b2f9194
c592d1b
01e368f
1d0b68b
346f634
6101c31
d963e00
ee8d200
406c954
3981f8b
51572ba
9cae2dc
772ccf9
8abbbd3
8bc48d7
a290488
474ab95
860de57
e15c0f1
f993c46
71cc6ce
803aacb
8daa5ab
7ba27a5
266aaab
0ee472f
56f1dfa
df7cd4f
60306f3
6acbd2f
f5322b6
2755352
9414ff8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is test project it doesn't belong here anymore. That can be updated in a follow-up though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it automatically get restored by arcade as a test project? Or can we assume it will never be run in an offline build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will get restored same as the build.proj and the repo-projects/ .proj files. But as mentioned, it might be better to do that in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like building this before the sdk version is determined, and the runtime config values aren't being set, so it'll need to be done here.
This file was deleted.