Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update dependencies from dotnet/aspnetcore #7420

Merged

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented May 7, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

  • Subscription: d39d88a2-8532-4615-fcea-08d7d0f045ee
  • Build: 20200514.13
  • Date Produced: 5/15/2020 4:19 AM
  • Commit: 035fb4e44140e13f320a7e0e1499cc835b9a6a03
  • Branch: refs/heads/master
  • Updates:
    • VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: from 5.0.0-preview.5.20255.6 to 5.0.0-preview.6.20264.13
    • dotnet-dev-certs: from 5.0.0-preview.5.20255.6 to 5.0.0-preview.6.20264.13
    • dotnet-user-secrets: from 5.0.0-preview.5.20255.6 to 5.0.0-preview.6.20264.13
    • Microsoft.AspNetCore.App.Runtime.win-x64: from 5.0.0-preview.5.20255.6 to 5.0.0-preview.6.20264.13
    • Microsoft.AspNetCore.App.Ref: from 5.0.0-preview.5.20255.6 to 5.0.0-preview.6.20264.13
    • dotnet-watch: from 5.0.0-preview.5.20255.6 to 5.0.0-preview.6.20264.13

…0200506.9

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20256.9
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20256.9
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20256.9
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20256.9
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20256.9
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20256.9
@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 7, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot added 8 commits May 7, 2020 21:20
…0200507.2

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.2
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.2
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.2
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.2
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.2
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.2
…0200507.7

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.7
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.7
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.7
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.7
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.7
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.7
…0200507.11

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.11
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.11
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.11
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.11
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.11
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20257.11
…0200508.1

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.1
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.1
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.1
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.1
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.1
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.1
…0200508.4

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.4
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.4
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.4
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.4
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.4
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.4
…0200508.5

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.5
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.5
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.5
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.5
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.5
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.5
…0200508.7

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.7
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.7
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.7
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.7
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.7
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.7
…0200508.11

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.11
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.11
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.11
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.11
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.11
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20258.11
@wli3
Copy link

wli3 commented May 10, 2020

@nkolev92 @zivkan This test failed trying to copy C:\Users\wul.nuget\packages\microsoft.aspnetcore.app.runtime.win-x64\5.0.0-preview.5.20258.11\runtimes\win-x64\lib\netcoreapp5.0\Microsoft.AspNetCore.Antiforgery.dll

However, aspnet microsoft.aspnetcore.app.runtime.win-x64 already moved to 5.0.0-preview.5.20258.11\runtimes\win-x64\lib\net5.0 Did we miss an update from nuget?

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 10, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Darwin Build_Release), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

…0200510.1

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20260.1
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20260.1
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20260.1
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20260.1
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20260.1
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20260.1
@nkolev92
Copy link

@wli3 Can you find the nuget assemblies version of the tooling used?

@nkolev92
Copy link

This PR has been open for way too long at this point: dotnet/sdk#11594

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 11, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Darwin Build_Release), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@zivkan
Copy link
Member

zivkan commented May 11, 2020

I think Nikolche means this PR, as it targets the master branch, just as this PR does: dotnet/sdk#11188

Rob's NuGetFramework changes to support the net5.0 (without platform support) was in NuGet build 6489, and PR 11188 makes it look like the master branch is already using build 6532, so I hope the NuGet bits are ok.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 11, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Darwin Build_Release), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@wli3
Copy link

wli3 commented May 11, 2020

Thanks for the investigation

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 11, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Darwin Build_Release), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@zivkan
Copy link
Member

zivkan commented May 12, 2020

I tried cloning the repo, checking out this PR's branch and running run-build.ps1, but it succeeds without errors. Any suggestions on how to reproduce the error locally, so I can better understand what's actually happening?

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Darwin Build_Release), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot added 2 commits May 12, 2020 00:58
…0200511.8

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20261.8
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20261.8
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20261.8
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20261.8
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20261.8
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.5.20261.8
…0200511.9

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.9
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.9
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.9
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.9
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.9
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.9
@wli3
Copy link

wli3 commented May 12, 2020

in VS developer prompt run

build.cmd
artifacts\sdk-build-env.bat
devenv Microsoft.DotNet.Cli.sln

then you can use VS test explorer to run the test

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Darwin Build_Release), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

…0200511.11

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.11
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.11
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.11
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.11
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.11
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20261.11
@zivkan
Copy link
Member

zivkan commented May 12, 2020

@wli3 since this package is of type DotnetPlatform, and not a "normal" library/dependency, I'm really not sure how asset selection is supposed to work. NuGet doesn't do it (it's not in the assets file). The package also doesn't contain a msbuild targets/props file. Maybe something in the SDK is using NuGet.Frameworks.dll, but for all I know it's programantically generating the short folder name from the TargetFrameworkIdentifier (.NETCoreApp) and TargetFrameworkVersion (5.0), and therefore generating netcoreapp5.0, whereas NuGet is now generating net5.0 for this TFI & TFV combo.

If that's the case, once the MSBuild target framework intrinsics PR (dotnet/msbuild#5234) is merged, the SDK could use that, but until then I think it needs to duplicate the logic that netcoreapp5.0 should be net5.0 instead.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Darwin Build_Release), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@zivkan
Copy link
Member

zivkan commented May 12, 2020

After remembering about binlogs, I think the items are being created by the ResolveRuntimePackAssets task, defined in Microsoft.NET.Sdk.FrameworkReferenceResolution.targets

edit: after looking at the task code, it reads data\RuntimeList.xml, and that has the netcoreapp5.0 folder name in the file paths. The package needs to be fixed and republished.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot added 5 commits May 12, 2020 19:04
…0200512.2

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.2
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.2
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.2
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.2
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.2
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.2
…0200512.7

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.7
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.7
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.7
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.7
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.7
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.7
…0200512.9

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.9
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.9
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.9
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.9
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.9
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20262.9
…0200513.1

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.1
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.1
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.1
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.1
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.1
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.1
…0200513.4

- VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.4
- dotnet-dev-certs: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.4
- dotnet-user-secrets: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.4
- Microsoft.AspNetCore.App.Runtime.win-x64: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.4
- Microsoft.AspNetCore.App.Ref: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.4
- dotnet-watch: 5.0.0-preview.5.20255.6 -> 5.0.0-preview.6.20263.4
@wli3
Copy link

wli3 commented May 13, 2020

@JunTaoLuo could you update data\RuntimeList.xml?

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@JunTaoLuo
Copy link

Ah this is currently blocked on us updating our TFM to net5.0 see the progress at dotnet/aspnetcore#21630

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot added 2 commits May 13, 2020 21:36
…0200513.5

VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0 , dotnet-dev-certs , dotnet-user-secrets , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref , dotnet-watch
 From Version 5.0.0-preview.5.20255.6 -> To Version 5.0.0-preview.6.20263.5
…0200513.8

VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0 , dotnet-dev-certs , dotnet-user-secrets , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref , dotnet-watch
 From Version 5.0.0-preview.5.20255.6 -> To Version 5.0.0-preview.6.20263.8
@wli3
Copy link

wli3 commented May 14, 2020

@JunTaoLuo could you drive this aspnet insertion to SDK? IE we will not actively monitor this PR. And you can update this to the latest aspnet (or via darc) and merge it when dotnet/aspnetcore#21630 is resolved

@dotnet-maestro
Copy link
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@JunTaoLuo
Copy link

cc @dougbu since he's actively working on the PR in aspnetcore. Let me know if you need any help Doug.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 14, 2020

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Arm64_Debug), installer (build Linux Build_Arm_Debug), installer (build Darwin Build_Release), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Windows_NT Build_Release_arm64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_arm), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot added 4 commits May 14, 2020 21:04
…0200514.3

VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0 , dotnet-dev-certs , dotnet-user-secrets , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref , dotnet-watch
 From Version 5.0.0-preview.5.20255.6 -> To Version 5.0.0-preview.6.20264.3
…0200514.5

VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0 , dotnet-dev-certs , dotnet-user-secrets , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref , dotnet-watch
 From Version 5.0.0-preview.5.20255.6 -> To Version 5.0.0-preview.6.20264.5
…0200514.9

VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0 , dotnet-dev-certs , dotnet-user-secrets , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref , dotnet-watch
 From Version 5.0.0-preview.5.20255.6 -> To Version 5.0.0-preview.6.20264.9
…0200514.13

VS.Redist.Common.AspNetCore.TargetingPack.x64.5.0 , dotnet-dev-certs , dotnet-user-secrets , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.App.Ref , dotnet-watch
 From Version 5.0.0-preview.5.20255.6 -> To Version 5.0.0-preview.6.20264.13
@dotnet-maestro dotnet-maestro bot merged commit fcc5d17 into master May 15, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-b9510476-0b37-4dca-81af-91811c2d3c98 branch May 15, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants