[master] Update dependencies from nuget/nuget.client #11188

dotnet-maestro · 2020-04-07T21:23:29Z

This pull request updates the following dependencies

From https://github.com/NuGet/NuGet.Client

Subscription: be39118f-8347-4151-a885-08d7219800a1
Build: 5.7.0.6609
Date Produced: 5/6/2020 11:02 PM
Commit: 12a375a8a02764b772a20371abaf797639a7f961
Branch: dev
Updates:
- NuGet.Build.Tasks: from 5.6.0-preview.2.6532 to 5.7.0-preview.1.6609

…5.6.0.6558 - NuGet.Build.Tasks - 5.6.0-preview.3.6558

dotnet-maestro · 2020-04-07T21:28:31Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)

sfoslund · 2020-04-10T15:54:07Z

@dsplaisted @wli3 build here is failing because we're being warned that there's an implicit reference to Microsoft.NETFramework.ReferenceAssemblies. Do we want to stop treating this warning as an error or should I make a patch to #10981 to not include the implicit package reference if there's an explicit one?

dotnet-maestro · 2020-04-10T15:57:44Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)

dsplaisted · 2020-04-10T16:04:16Z

@sfoslund I think if we can we should update the logic so that it will only add the implicit reference if there's not an explicit one already. I probably should have caught that in the code review.

If we're blocked on updating dependencies due to this, we can temporarily ignore the warning (or maybe just remove the explicit PackageReferences to the reference assembly package).

dotnet-maestro · 2020-04-10T16:07:48Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release)

sfoslund · 2020-04-10T16:42:56Z

@dsplaisted I'll try to get a fix out to master by EOD today, but it's too late for prev 3, right? If we need to update stage 0 in prev 3 then we'll likely run into this issue and have to temporarily ignore the warning.

dotnet-maestro · 2020-04-10T16:43:02Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

…5.7.0.6568 - NuGet.Build.Tasks: 5.6.0-preview.2.6532 -> 5.7.0-preview.1.6568

sfoslund · 2020-04-20T16:44:19Z

/azp run

azure-pipelines · 2020-04-20T16:44:28Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-maestro · 2020-04-20T16:46:44Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

dsplaisted · 2020-04-23T15:40:43Z

@sfoslund Are you looking at this? It looks like it may now be failing with a different problem:

ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(376,5): error : Error: [F:\workspace_work\1\s\artifacts\tmp\Release\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace_work\1\s\artifacts\bin\redist\Release\dotnet\sdk\5.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(376,5): error : An assembly specified in the application dependencies manifest (crossgen2.deps.json) was not found: [F:\workspace_work\1\s\artifacts\tmp\Release\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace_work\1\s\artifacts\bin\redist\Release\dotnet\sdk\5.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(376,5): error : package: 'runtimepack.Microsoft.NETCore.App.Runtime.win-x64', version: '5.0.0-preview.3.20169.1' [F:\workspace_work\1\s\artifacts\tmp\Release\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace_work\1\s\artifacts\bin\redist\Release\dotnet\sdk\5.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(376,5): error : path: 'SOS_README.md' [F:\workspace_work\1\s\artifacts\tmp\Release\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace_work\1\s\artifacts\bin\redist\Release\dotnet\sdk\5.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(376,5): error : Error: [F:\workspace_work\1\s\artifacts\tmp\Release\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace_work\1\s\artifacts\bin\redist\Release\dotnet\sdk\5.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(376,5): error : An assembly specified in the application dependencies manifest (crossgen2.deps.json) was not found: [F:\workspace_work\1\s\artifacts\tmp\Release\TestProjectPu---56D735CE\Crossgen2TestApp\Crossgen2TestApp.csproj]\r\nF:\workspace_work\1\s\artifacts\bin\redist\Release\dotnet\sdk\5.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(376,5): error : package:

dotnet-maestro · 2020-04-23T15:41:01Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

sfoslund · 2020-04-23T15:53:10Z

@dsplaisted I think stage 0 needs to be updated to get the changes from #11242, but as the official build is broken I haven't been able to do that.

dotnet/arcade#5329 is tracking the issue with the official build.

dotnet-maestro · 2020-04-23T15:56:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

dsplaisted · 2020-04-27T18:26:02Z

@sfoslund Do we have successful official builds by now that we can use to update stage 0?

dotnet-maestro · 2020-04-27T18:26:42Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

sfoslund · 2020-04-27T18:51:24Z

This build was the first to succeed in the publishing step https://dev.azure.com/dnceng/internal/_build/results?buildId=619386&view=results but we've been seeing CopyToLatest issues as well. There's some discussion of fixes for this on the original arcade issue, see this comment: dotnet/arcade#5329 (comment).

dotnet-maestro · 2020-04-27T18:51:56Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

ViktorHofer · 2020-04-27T18:56:39Z

I'm taking care of the "copy to latest" failure in dotnet/installer#7327.

dotnet-maestro · 2020-04-27T18:56:59Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)

…f18744

…5.7.0.6592 - NuGet.Build.Tasks: 5.6.0-preview.2.6532 -> 5.7.0-preview.1.6592

sfoslund · 2020-04-28T16:01:40Z

@dsplaisted the build warnings caused by the ref assemblies are resolved but we're seeing some publishing test failures. These are the failing tests:

sdk/src/Tests/dotnet-restore.Tests/GivenThatIWantToRestoreApp.cs

Line 80 in 983c811

Directory.Exists(fullPath).Should().BeTrue();

and

sdk/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishReadyToRun.cs

Line 205 in 873d79d

    
           TestProjectPublishing_Internal("Crossgen2TestApp", targetFramework, isSelfContained: true, emitNativeSymbols: true, useCrossgen2: true);

Do you recognize any of the errors?

dotnet-maestro · 2020-04-28T16:06:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)

ViktorHofer · 2020-04-29T08:24:57Z

@sfoslund can you please update stage 0 to 5.0.100-preview.5.20228.8 which includes the runtime regression fix? The 227.9 one doesn't have the fix.

kartheekp-ms · 2020-05-08T18:06:48Z

@kartheekp-ms Is on NuGet hotseat this week and ran the commands. Did you update your darc tool before running the commands?

no @zivkan. I missed "Always update to the latest darc before publishing!" instruction in our OneNote doc. Can I execute the commands again after updating the darc automation tool ?

mmitche · 2020-05-08T18:09:29Z

@kartheekp-ms Is on NuGet hotseat this week and ran the commands. Did you update your darc tool before running the commands?

no @zivkan. I missed "Always update to the latest darc before publishing!" instruction in our OneNote doc. Can I execute the commands again after updating the darc automation tool ?

No need. I ran them. I first removed the build from the channels and re-added it:

darc delete-build-from-channel --id 51041 --channel ".NET 5 Preview 5"
darc delete-build-from-channel --id 51041 --channel ".NET 5 Dev"
darc delete-build-from-channel --id 51041 --channel ".NET Core SDK 3.1.4xx"

darc add-build-to-channel --id 51041 --channel ".NET Core SDK 3.1.4xx" --source-branch master
darc add-build-to-channel --id 51041 --channel ".NET 5 Dev" --source-branch master

dotnet-maestro · 2020-05-08T18:10:49Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

rrelyea · 2020-05-08T18:25:24Z

@mmitche - can the darc tool be made so that old versions don't let you run them?
(not sure how important that is...but might be nice)

dotnet-maestro · 2020-05-08T18:25:55Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

mmitche · 2020-05-08T18:29:20Z

@mmitche - can the darc tool be made so that old versions don't let you run them?
(not sure how important that is...but might be nice)

I'm opposed to this, as there is a release of darc almost every week. Most darc functionality doesn't change release to release, so disabling usage of those darc is pretty crappy (also there are offline scenarios where darc can't contact to do an up to date check anyway). It's really just in this case that the darc version that was being used is very old (at least 3-4 months?) and doesn't even have the required capabilities. Newer darc versions will tell you if they aren't compatible.

dotnet-maestro · 2020-05-08T18:30:58Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

ViktorHofer · 2020-05-08T18:33:15Z

Newer darc versions will tell you if they aren't compatible.

👍

dotnet-maestro · 2020-05-08T18:36:00Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release)

Hopefully this will fix flaky failures for this test

nkolev92 · 2020-05-11T23:42:19Z

ItRestoresLibToSpecificDirectory seems to be failing again (similar to some previous insertions).

Given the test name, I'm wondering if there could be an environment variable set that makes this fail occassionaly.

The variables to look at are:

NUGET_PACKAGES or RestorePackagesPath, which is the MSBuild property NuGet reads.

dotnet-maestro · 2020-05-11T23:42:35Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release)

dsplaisted · 2020-05-12T00:27:01Z

@nkolev92 I've updated the test to dump the assets file contents if the assertion fails. Would that be likely to contain information to help understand the failures?

dotnet-maestro · 2020-05-12T00:27:57Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_Perf_CI Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

nkolev92 · 2020-05-12T00:35:57Z

@dsplaisted

Yeah, that should help.

dotnet-maestro · 2020-05-12T00:38:02Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release)

dsplaisted · 2020-05-12T16:53:53Z

Looking at the assets file from the CI run, it looks like the problem is that the test is creating a .NET 5 class library, which doesn't depend on any package references. When I run it locally in VS however, it creates a .NET Standard 2.0 class library, which does depend on some packages, so the test passes.

dotnet-maestro · 2020-05-12T16:56:09Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

dsplaisted · 2020-05-12T17:05:21Z

@wli3 OK, so the reason this wasn't failing locally for any of us is because locally we use v5.0.100-dev for the SDK version, and once the classlib template had been populated in that folder in .templateengine, it doesn't get updated when the template changes (ie from targeting .NET Standard 2.0 to .NET 5).

Isolating DOTNET_CLI_HOME to the repo could help with this (though you would still probably need to delete the folder in the local artifacts folder).

dotnet-maestro · 2020-05-12T17:06:14Z

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

✔️ All Checks Successful Succeeded - Successful checks: license/cla, dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Windows_Perf_CI_FullFramework Build_Release), dotnet-sdk-public-ci (Build Linux_Perf_CI Build_Release), dotnet-sdk-public-ci (Build Windows_Perf_CI Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)

Classlib template now targets .NET 5 which doesn't require any implicit package references

nkolev92 · 2020-05-12T19:39:46Z

yay 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🎈 🎈 🎈🎈 🎈 🎈🎈 🎈 🎈🎈 🎈 🎈🎈 🎈 🎈🎈 🎈 🎈

kartheekp-ms · 2020-05-14T21:12:21Z

No need. I ran them. I first removed the build from the channels and re-added it:

darc delete-build-from-channel --id 51041 --channel ".NET 5 Preview 5"
darc delete-build-from-channel --id 51041 --channel ".NET 5 Dev"
darc delete-build-from-channel --id 51041 --channel ".NET Core SDK 3.1.4xx"

darc add-build-to-channel --id 51041 --channel ".NET Core SDK 3.1.4xx" --source-branch master
darc add-build-to-channel --id 51041 --channel ".NET 5 Dev" --source-branch master

@mmitche - I am unable to locate quickly if there was any PR created in dotnet/cli repo for this insertion. I found a PR in .NET CLI repo for previous insertion but not for the current one.

.NET Core insertion
- 3.x
- 5.x
  - SDK - [master] Update dependencies from nuget/nuget.client #11188

/cc @donnie-msft

kartheekp-ms · 2020-05-15T14:31:44Z

@mmitche - Thanks you for helping us by creating a PR insertion in to CLI repo dotnet/cli#13358

Update dependencies from https://github.com/NuGet/NuGet.Client build …

614c388

…5.6.0.6558 - NuGet.Build.Tasks - 5.6.0-preview.3.6558

Updating stage 0

854449a

sfoslund mentioned this pull request Apr 11, 2020

Single automatic assembly pack package reference #11242

Merged

Update dependencies from https://github.com/NuGet/NuGet.Client build …

d730ec8

…5.7.0.6568 - NuGet.Build.Tasks: 5.6.0-preview.2.6532 -> 5.7.0-preview.1.6568

sfoslund and others added 3 commits April 27, 2020 12:33

Update stage 0

c1bdd71

Merge branch 'master' into darc-master-335a5c45-e150-4fd7-8231-4f6161…

3b37398

…f18744

Update dependencies from https://github.com/NuGet/NuGet.Client build …

3336930

…5.7.0.6592 - NuGet.Build.Tasks: 5.6.0-preview.2.6532 -> 5.7.0-preview.1.6592

Use different test directories for test

16eaa8f

Hopefully this will fix flaky failures for this test

zivkan mentioned this pull request May 11, 2020

[master] Update dependencies from dotnet/aspnetcore dotnet/installer#7420

Merged

Add logging for assets file contents if assertion fails

15742b6

dsplaisted force-pushed the darc-master-335a5c45-e150-4fd7-8231-4f6161f18744 branch from 8bed5eb to 15742b6 Compare May 12, 2020 15:06

dsplaisted mentioned this pull request May 12, 2020

[master] Update dependencies from dotnet/runtime #11588

Merged

Fix test to explicitly reference package

32b1c75

Classlib template now targets .NET 5 which doesn't require any implicit package references

dotnet-maestro bot merged commit 0007f9d into master May 12, 2020

dotnet-maestro bot deleted the darc-master-335a5c45-e150-4fd7-8231-4f6161f18744 branch May 12, 2020 19:37

[master] Update dependencies from nuget/nuget.client #11188

[master] Update dependencies from nuget/nuget.client #11188

Conversation

dotnet-maestro bot commented Apr 7, 2020 • edited Loading

From https://github.com/NuGet/NuGet.Client

dotnet-maestro bot commented Apr 7, 2020 • edited Loading

Auto-Merge Status

sfoslund commented Apr 10, 2020

dotnet-maestro bot commented Apr 10, 2020 • edited Loading

Auto-Merge Status

dsplaisted commented Apr 10, 2020

dotnet-maestro bot commented Apr 10, 2020 • edited Loading

Auto-Merge Status

sfoslund commented Apr 10, 2020

dotnet-maestro bot commented Apr 10, 2020 • edited Loading

Auto-Merge Status

sfoslund commented Apr 20, 2020

azure-pipelines bot commented Apr 20, 2020

dotnet-maestro bot commented Apr 20, 2020 • edited Loading

Auto-Merge Status

dsplaisted commented Apr 23, 2020

dotnet-maestro bot commented Apr 23, 2020 • edited Loading

Auto-Merge Status

sfoslund commented Apr 23, 2020

dotnet-maestro bot commented Apr 23, 2020 • edited Loading

Auto-Merge Status

dsplaisted commented Apr 27, 2020

dotnet-maestro bot commented Apr 27, 2020 • edited Loading

Auto-Merge Status

sfoslund commented Apr 27, 2020

dotnet-maestro bot commented Apr 27, 2020

Auto-Merge Status

ViktorHofer commented Apr 27, 2020 • edited Loading

dotnet-maestro bot commented Apr 27, 2020 • edited Loading

Auto-Merge Status

sfoslund commented Apr 28, 2020

dotnet-maestro bot commented Apr 28, 2020 • edited Loading

Auto-Merge Status

ViktorHofer commented Apr 29, 2020

kartheekp-ms commented May 8, 2020

mmitche commented May 8, 2020

dotnet-maestro bot commented May 8, 2020 • edited Loading

Auto-Merge Status

rrelyea commented May 8, 2020

dotnet-maestro bot commented May 8, 2020

Auto-Merge Status

mmitche commented May 8, 2020

dotnet-maestro bot commented May 8, 2020

Auto-Merge Status

ViktorHofer commented May 8, 2020

dotnet-maestro bot commented May 8, 2020 • edited Loading

Auto-Merge Status

nkolev92 commented May 11, 2020

dotnet-maestro bot commented May 11, 2020 • edited Loading

Auto-Merge Status

dsplaisted commented May 12, 2020

dotnet-maestro bot commented May 12, 2020 • edited Loading

Auto-Merge Status

nkolev92 commented May 12, 2020

dotnet-maestro bot commented May 12, 2020 • edited Loading

Auto-Merge Status

dsplaisted commented May 12, 2020

dotnet-maestro bot commented May 12, 2020 • edited Loading

Auto-Merge Status

dsplaisted commented May 12, 2020

dotnet-maestro bot commented May 12, 2020 • edited Loading

Auto-Merge Status

nkolev92 commented May 12, 2020

kartheekp-ms commented May 14, 2020 • edited Loading

kartheekp-ms commented May 15, 2020

dotnet-maestro bot commented Apr 7, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 7, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 10, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 10, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 10, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 20, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 23, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 23, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 27, 2020 •

edited

Loading

ViktorHofer commented Apr 27, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 27, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 28, 2020 •

edited

Loading

dotnet-maestro bot commented May 8, 2020 •

edited

Loading

dotnet-maestro bot commented May 8, 2020 •

edited

Loading

dotnet-maestro bot commented May 11, 2020 •

edited

Loading

dotnet-maestro bot commented May 12, 2020 •

edited

Loading

dotnet-maestro bot commented May 12, 2020 •

edited

Loading

dotnet-maestro bot commented May 12, 2020 •

edited

Loading

dotnet-maestro bot commented May 12, 2020 •

edited

Loading

kartheekp-ms commented May 14, 2020 •

edited

Loading