Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update dependencies from dotnet/runtime #11588

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 8, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: ea219f43-0754-4d2f-576e-08d76e1d56cb
  • Build: 20200512.14
  • Date Produced: 5/13/2020 3:06 AM
  • Commit: bc3bec788cd8d1f9d882b359ca8368248bf051a4
  • Branch: refs/heads/master
  • Updates:
    • System.CodeDom: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • Microsoft.NET.HostModel: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • Microsoft.Extensions.DependencyModel: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • Microsoft.NETCore.DotNetHostResolver: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • Microsoft.NETCore.App.Ref: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • System.Security.Cryptography.ProtectedData: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • System.Text.Encoding.CodePages: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14
    • System.Resources.Extensions: from 5.0.0-preview.5.20253.7 to 5.0.0-preview.6.20262.14

…0507.11

- System.CodeDom: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NET.HostModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NETCore.DotNetHostResolver: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- System.Security.Cryptography.ProtectedData: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- System.Text.Encoding.CodePages: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- System.Resources.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 8, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot and others added 4 commits May 9, 2020 12:12
…0508.3

- System.CodeDom: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NET.HostModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NETCore.DotNetHostResolver: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- System.Security.Cryptography.ProtectedData: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- System.Text.Encoding.CodePages: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- System.Resources.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
…0509.5

- System.CodeDom: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NET.HostModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NETCore.DotNetHostResolver: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- System.Security.Cryptography.ProtectedData: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- System.Text.Encoding.CodePages: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- System.Resources.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
…0510.5

- System.CodeDom: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- Microsoft.NET.HostModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- Microsoft.NETCore.DotNetHostResolver: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- System.Security.Cryptography.ProtectedData: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- System.Text.Encoding.CodePages: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
- System.Resources.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5
@eerhardt
Copy link
Member

@wli3 @dsplaisted - I fixed the first build problem by updating the TFM from netcoreapp5.0 to net5.0, but now that is causing another issue. Can you take a look?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

Should support net5.0 TargetFramework
@dsplaisted
Copy link
Member

@eerhardt I've updated stage 0 to a newer SDK, I think that will help.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@wli3
Copy link

wli3 commented May 12, 2020

@ViktorHofer ItRestoresLibToSpecificDirectory is failing. May related to https://github.com/dotnet/sdk/pull/10794/files. Could you have a look?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@wli3
Copy link

wli3 commented May 12, 2020

hmm ItRestoresLibToSpecificDirectory is flaky now. Fail most of the time. I cannot repro locally

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@wli3
Copy link

wli3 commented May 12, 2020

try print the log over this #11614

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ViktorHofer
Copy link
Member

@ViktorHofer ItRestoresLibToSpecificDirectory is failing. May related to https://github.com/dotnet/sdk/pull/10794/files. Could you have a look?

cc @nkolev92 @jeffkl

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

…0511.9

- System.CodeDom: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- Microsoft.NET.HostModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- Microsoft.NETCore.DotNetHostResolver: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- System.Security.Cryptography.ProtectedData: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- System.Text.Encoding.CodePages: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
- System.Resources.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20261.9
@dsplaisted
Copy link
Member

The same test is failing over on #11188. I'm trying dumping the assets file contents to see if that helps us figure out what's going on.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 12, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot and others added 2 commits May 13, 2020 12:11
…0512.14

- System.CodeDom: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- Microsoft.NET.HostModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- Microsoft.NETCore.DotNetHostResolver: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- System.Security.Cryptography.ProtectedData: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- System.Text.Encoding.CodePages: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
- System.Resources.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.6.20262.14
@eerhardt
Copy link
Member

I'm fixing the last test issue with this PR:

Assert.Equal() Failure\nExpected: 6\nActual: 14

Stack trace
   at Microsoft.DotNet.Cli.Utils.Tests.RuntimeEnvironmentTests.VerifyMacOs() in /_/src/Tests/Microsoft.DotNet.Cli.Utils.Tests/RuntimeEnvironmentTests.cs:line 41

This was caused by dotnet/runtime#36029 and is expected (for now). In a follow up PR my plan is to remove the OSX and Windows version code in RuntimeEnvironment and just use Environment.OSVersion directly now that dotnet/runtime#34977 and dotnet/runtime#33643 are fixed in net5.0.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented May 13, 2020

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Linux_Perf_CI Build_Release), dotnet-sdk-public-ci (Build Windows_Perf_CI_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_Perf_CI Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@dotnet-maestro dotnet-maestro bot merged commit a5e30db into master May 13, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-77f307ec-7455-4c31-92ba-9a9e6e8daaeb branch May 13, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants