Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CombineLinkerXmlFiles task #1234

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jun 3, 2020

This task combines multiple linker xml files into a single, combined xml file.

@sbomer @marek-safar

This task combines multiple linker xml files into a single, combined xml file.
@eerhardt
Copy link
Member Author

eerhardt commented Jun 3, 2020

An example of using this task is here:

dotnet/runtime#37288

Which makes the first System.Private.CoreLib substitutions xml file. And then we can add more xml files to be combined together like this sample: dotnet/runtime@9678f41

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@sbomer sbomer merged commit 12dc3cc into dotnet:master Jun 3, 2020
@eerhardt eerhardt deleted the CombineLinkerXmlFiles branch June 3, 2020 19:22
tlakollo pushed a commit to tlakollo/linker that referenced this pull request Jun 4, 2020
* Add CombineLinkerXmlFiles task

This task combines multiple linker xml files into a single, combined xml file.

* Fix formatting
tkapin pushed a commit to tkapin/runtime that referenced this pull request Jan 31, 2023
* Add CombineLinkerXmlFiles task

This task combines multiple linker xml files into a single, combined xml file.

* Fix formatting

Commit migrated from dotnet/linker@12dc3cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants