Define Debugger.IsSupported feature switch to allow trimming of debugger only code. #37288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
jkotas
reviewed
Jun 2, 2020
marek-safar
reviewed
Jun 2, 2020
src/libraries/System.Private.CoreLib/src/ILLink.Substitutions.xml
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
This was referenced Jun 2, 2020
eerhardt
added
the
linkable-framework
This was referenced Jun 25, 2020
eerhardt
force-pushed
the
DebuggingFeatureSwitch
branch
from
12fda40 to
fc3ae5a
Compare
eerhardt
changed the title
|
I believe this is ready for review now, if anyone wants to take a look. |
stephentoub
approved these changes
Jul 10, 2020
marek-safar
approved these changes
Jul 10, 2020
eerhardt
added a commit
to eerhardt/sdk
that referenced
this pull request
Jul 14, 2020
…gation These feature switches were added in the runtime: * Debugger - dotnet/runtime#37288 * Http activity propagation - dotnet/runtime#38765 Fix dotnet#12217
eerhardt
added a commit
to dotnet/sdk
that referenced
this pull request
Jul 15, 2020
…gation (#12457) These feature switches were added in the runtime: * Debugger - dotnet/runtime#37288 * Http activity propagation - dotnet/runtime#38765 Fix #12217
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new feature switch that enables code that is only used for debugging to be trimmed by the ILLinker.
So far, there are 2 sets of code that can be trimmed:
In the future, once dotnet/linker#1162 is implemented, we should be able to use this same feature switch to remove the
DebuggerTypeProxyAttributewhen this feature switch is enabled. That will allow us to remove the debugger proxy types as well.With this feature switch enabled, I'm seeing a ~8KB size change in the CarChecker Blazor WASM app: