Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WarningsAsErrors and WarningsNotAsErrors #1388

Merged
merged 6 commits into from
Jul 27, 2020

Conversation

mateoatr
Copy link
Contributor

Adds the ILLink Task options WarningsAsErrors and WarningsNotAsErrors which map to the command-line options --warnaserror and --warnaserror- respectively.

@mateoatr mateoatr self-assigned this Jul 24, 2020
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion - otherwise LGTM. Thanks!

src/ILLink.Tasks/LinkTask.cs Outdated Show resolved Hide resolved
src/ILLink.Tasks/LinkTask.cs Outdated Show resolved Hide resolved
mateoatr and others added 2 commits July 27, 2020 09:48
Co-authored-by: Vitek Karas <vitek.karas@microsoft.com>
@mateoatr mateoatr merged commit 6252b94 into dotnet:master Jul 27, 2020
@sbomer sbomer mentioned this pull request Jul 30, 2020
tkapin pushed a commit to tkapin/runtime that referenced this pull request Jan 31, 2023
* Add WarningsAsErrors and WarningsNotAsErrors to ILLinkTask

* Add TreatWarningsAsErrors

Commit migrated from dotnet/linker@6252b94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants