-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WarningsAsErrors and WarningsNotAsErrors #1388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
reviewed
Jul 24, 2020
sbomer
reviewed
Jul 24, 2020
sbomer
approved these changes
Jul 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion - otherwise LGTM. Thanks!
vitek-karas
approved these changes
Jul 27, 2020
Co-authored-by: Vitek Karas <vitek.karas@microsoft.com>
Closed
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
* Add WarningsAsErrors and WarningsNotAsErrors to ILLinkTask * Add TreatWarningsAsErrors Commit migrated from dotnet/linker@6252b94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ILLink Task options
WarningsAsErrors
andWarningsNotAsErrors
which map to the command-line options--warnaserror
and--warnaserror-
respectively.