Pass warning options to ILLink #12636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
force-pushed
the
illinkWarnOptions
branch
3 times, most recently
from
0654a0e
to
db80473
Compare
mateoatr
reviewed
Aug 5, 2020
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs
Outdated
Show resolved
Hide resolved
jmarolf
approved these changes
Aug 5, 2020
Avoid testing via an empty string, which doesn't play nicely with the AnalysisLevel logic that expects a version.
sbomer
force-pushed
the
illinkWarnOptions
branch
from
d4668db
to
7cf69e8
Compare
sbomer
force-pushed
the
illinkWarnOptions
branch
from
7cf69e8
to
1a53813
Compare
vitek-karas
approved these changes
Aug 10, 2020
|
Merging since the remaining ci leg passed in the pipeline (https://dev.azure.com/dnceng/public/_build/results?buildId=763802&view=logs&j=adc369b2-ee17-52c3-72b2-7129c9e8cda1) despite it not showing on the github status check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12601.
This depends on #12422 forAnalysisLevel, dotnet/linker#1388 for some of the task options.Depends on #12388 for the new linker warnings to be disabled by default.