Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DotNetFinalVersionKind variable in yml #170

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Fix DotNetFinalVersionKind variable in yml #170

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8e63535
Fix DotNetFinalVersionKind variable in yml
carlossanlop Nov 12, 2024
048de51
Prevent passing var in public
carlossanlop Nov 12, 2024
9092bcc
Merge remote-tracking branch 'origin/FixYml' into FixYml
carlossanlop Nov 14, 2024
492ee3c
Try with $ ( )
carlossanlop Nov 14, 2024
681534e
Use parameter
carlossanlop Nov 14, 2024
0dd40ce
Use empty default
carlossanlop Nov 14, 2024
2168687
Use prerelease as default
carlossanlop Nov 14, 2024
bcd5f17
Only allow the DotNetFinalVersionKind parameter usage in internal
carlossanlop Nov 14, 2024
24410b8
Try with 'none'
carlossanlop Nov 14, 2024
4340392
Use an if else for the variable value depending on none
carlossanlop Nov 14, 2024
0f929f3
Almost forgot to remove the property from the props
carlossanlop Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eng/pipelines/maintenance-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,15 @@ variables:
value: ''
- name: _BuildJobDisplayName
value: 'Build and Test'
- name: _DotNetFinalVersionKind
value: ''
- ${{ else }}:
- name: _AdditionalBuildArgs
value: '/p:Test=false'
- name: _BuildJobDisplayName
value: 'Build, Sign and Publish'
- name: _DotNetFinalVersionKind
carlossanlop marked this conversation as resolved.
Show resolved Hide resolved
value: /p:DotNetFinalVersionKind=${{ variables.DotNetFinalVersionKind }}
carlossanlop marked this conversation as resolved.
Show resolved Hide resolved

resources:
repositories:
Expand Down Expand Up @@ -91,7 +95,7 @@ extends:
-configuration Release
-prepareMachine
/p:Test=false
/p:DotNetFinalVersionKind=$(DotNetFinalVersionKind)
$(_DotNetFinalVersionKind)
$(_AdditionalBuildArgs)
$(_InternalBuildArgs)
displayName: $(_BuildJobDisplayName)
Expand Down