Removed scheduler debugger from MSBuildDebugEngine #10868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Oct 24, 2024
rainersigwald
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10639
Context
There was an internal ticket that seems to originate from the scheduler logger. The team uses the engine debugger variable to keep track of their builds. However, it seems that the scheduler logger does not always work as expected and it is turned on when using
MSBuildDebugEngine. Since we think there isn't a lot of information that is necessary from scheduler logger, we are trying to disable it when using theMSBuildDebugEnginevariable, and leaving it on when explicitly turned on.Changes Made
Does not turn on scheduler debugger when using
MSBuildDebugEngineTesting