Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Arcade 5.0 and .NET 5.0 #5836

Merged
merged 43 commits into from
Jan 20, 2021
Merged
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
fa19e25
Initial arcade update
benvillalobos Oct 26, 2020
a08fe7a
set global.json back to 3.1.100
benvillalobos Oct 27, 2020
dc86d60
Fix roslyn folder to look for netcoreapp3.1
benvillalobos Nov 25, 2020
f4d410f
Add empty constructor?
benvillalobos Nov 25, 2020
16ddaa0
Revert "Fix roslyn folder to look for netcoreapp2.1".
benvillalobos Nov 30, 2020
a59a108
Update to dotnet 5.0.100-rc.2.20479.15
benvillalobos Dec 4, 2020
cf61235
net5.0 was released already!
benvillalobos Dec 4, 2020
08e070d
Update versions.props to 5.0.100, how do we tie them together?
benvillalobos Dec 4, 2020
6755fdd
update dir.build.props and msft.build.csproj to use net5.0 targetfram…
benvillalobos Dec 4, 2020
a47579d
Update Directory.BeforeCommon.targets to account for net5.0
benvillalobos Dec 8, 2020
65892d5
WIP: Set replace netcoreapp2.1 with net5.0
benvillalobos Dec 8, 2020
02d7cae
Update (OS) to (OSEnvironment), nowarn on SYSLIB0011 (binaryformatter)
benvillalobos Dec 8, 2020
bf12a8e
Short out TPI
rainersigwald Dec 9, 2020
bd02547
Disambiguate order of operations
rainersigwald Dec 9, 2020
310e53b
Initialize value passed to TranslateDotNet
rainersigwald Dec 9, 2020
b6867fd
Relax nullable in COWDictionary deserialization
rainersigwald Dec 9, 2020
e7b81b4
Assume assembly path isn't a root
rainersigwald Dec 9, 2020
556bf53
IsOS check for PipeDrain
rainersigwald Dec 9, 2020
c51b459
Assume AssemblyName has a Name
rainersigwald Dec 9, 2020
1c17b5f
Get rid of OsEnvironment
rainersigwald Dec 9, 2020
e23a284
fixup! IsOS check for PipeDrain
rainersigwald Dec 9, 2020
35adbc5
Roslyn update from PR #5920.
benvillalobos Dec 9, 2020
966b4e4
Update arcade scripts to net5.0
benvillalobos Dec 10, 2020
3ac093a
MSBuild.csproj no longer uses apphost. This fixes an issue where cert…
benvillalobos Dec 18, 2020
26809de
Continue skipping over ValidateAssemblyLoadContext in net5.0
benvillalobos Dec 18, 2020
57b9fac
Infinity is not a valid double
benvillalobos Dec 18, 2020
47b749a
Restore AssemblyLoadContext name
rainersigwald Dec 18, 2020
a334038
look for netcoreapp2.1 arcade binaries
benvillalobos Dec 18, 2020
18fa14f
Revert to looking for arcade netcoreapp2.1 folder
benvillalobos Dec 18, 2020
195c471
Update Microsoft.Extensions.DependencyModel and Runtime.CompilerServi…
benvillalobos Dec 19, 2020
9ba9e5f
Only import M.E.DependencyModel 5.0.0 when on net core
benvillalobos Dec 22, 2020
8579df7
Add special check for mono on mac to import M.E.DependencyModel 5.0.0…
benvillalobos Dec 22, 2020
3d14064
remove osx check, keep monobuild check only
benvillalobos Dec 22, 2020
d1a83ca
Update arcade to fix signing issues
benvillalobos Jan 4, 2021
c4297a0
Remove stale comment, add comment explaining UseAppHost false
benvillalobos Jan 13, 2021
5d62686
Update dotnetcliversion to 5.0.102
benvillalobos Jan 13, 2021
60ddd86
Also update global.json and add a comment notifying future devs to up…
benvillalobos Jan 13, 2021
35fa031
Simplify NetCoreBuild check. Use istargetframeworkcompatible with net…
benvillalobos Jan 13, 2021
36880b6
Skip netcore check if on mono
benvillalobos Jan 13, 2021
9eafc9c
Catch-all condition for 'core-flavored' builds in the UpdateMSBuildDe…
benvillalobos Jan 13, 2021
72ef461
Fix condition
benvillalobos Jan 13, 2021
57fde7f
Prevent mono builds from seeing IsTargetFrameworkCompatible intrinsic…
benvillalobos Jan 13, 2021
e80a52b
Merge branch 'master' into arcade-update
benvillalobos Jan 15, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Copyright>$(CopyrightNetFoundation)</Copyright>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
</PropertyGroup>

<PropertyGroup>
<Product>Microsoft® Build Tools®</Product>
<Configurations>Debug;Release;Debug-MONO;Release-MONO;MachineIndependent</Configurations>
Expand All @@ -16,19 +16,6 @@
<FullFrameworkTFM>net472</FullFrameworkTFM>
</PropertyGroup>

<PropertyGroup>
<OsEnvironment Condition="$([MSBuild]::IsOSPlatform('windows'))">windows</OsEnvironment>
<OsEnvironment Condition="$([MSBuild]::IsOSPlatform('linux'))">linux</OsEnvironment>
<OsEnvironment Condition="$([MSBuild]::IsOSPlatform('osx'))">osx</OsEnvironment>
<!-- Replace with MSBuild::IsBsdLike once the initial msbuild knows about it -->
<OsEnvironment Condition="$([MSBuild]::IsOSPlatform('FREEBSD')) Or $([MSBuild]::IsOSPlatform('NETBSD')) Or $([MSBuild]::IsOSPlatform('OPENBSD'))">bsd</OsEnvironment>

<OsUnixLike>false</OsUnixLike>
<OsUnixLike Condition="$([MSBuild]::IsOsUnixLike())">true</OsUnixLike>

<TargetPlatformIdentifier Condition="'$(TargetPlatformIdentifier)'==''">$(OS)</TargetPlatformIdentifier>
</PropertyGroup>

<PropertyGroup>
<DOTNET_INSTALL_DIR Condition="'$(DOTNET_INSTALL_DIR)' == ''">$(RepoRoot).dotnet\</DOTNET_INSTALL_DIR>

Expand All @@ -49,9 +36,10 @@
CS1701 and CS1702 are by default ignored by Microsoft.NET.Sdk, but if you define the NoWarn property in Directory.Build.props,
you don't get those defaults.
NU5125: Arcade uses licenseUrl when doing pack, which now causes NU5125 warning. This disables that warning until arcade can switch over.
SYSLIB0011: Removing binary formatter will happen as part of a larger .NET-wide effort.
-->

<NoWarn>$(NoWarn);NU1603;NU5105;NU5125;1701;1702</NoWarn>
<NoWarn>$(NoWarn);NU1603;NU5105;NU5125;1701;1702;SYSLIB0011</NoWarn>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Debug-MONO'">
Expand Down
5 changes: 5 additions & 0 deletions eng/Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
<PackageReference Update="System.Reflection.TypeExtensions" Version="4.1.0" />
<PackageReference Update="System.Resources.Extensions" Version="4.6.0" />
<PackageReference Update="System.Resources.Writer" Version="4.0.0" />
<PackageReference Update="System.Runtime.CompilerServices.Unsafe" Version="5.0.0"/>
<PackageReference Update="System.Runtime.InteropServices" Version="4.3.0" />
<PackageReference Update="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
<PackageReference Update="System.Runtime.Loader" Version="4.0.0" />
Expand All @@ -46,6 +47,10 @@
<PackageReference Update="xunit.core" Version="$(XUnitVersion)" />
</ItemGroup>

<ItemGroup Condition="'$(MonoBuild)' == 'true' or $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'netcoreapp2.1'))">
<PackageReference Update="Microsoft.Extensions.DependencyModel" Version="5.0.0"/>
</ItemGroup>

<ItemGroup Condition="'$(DotNetBuildFromSource)' != 'true'">
<GlobalPackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="All"/>
</ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.20580.3">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.20621.10">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>7ee8c2b620e66b3762d7a5a688dee8238770c86a</Sha>
<Sha>6813f5aa511a7a4498fa217a54219b5704a01f83</Sha>
</Dependency>
<Dependency Name="NuGet.Build.Tasks" Version="5.9.0-preview.2.6979">
<Uri>https://github.com/NuGet/NuGet.Client</Uri>
<Sha>8e3cdf1b3475a0cb68a65dd2ffd51a2135f1fb67</Sha>
</Dependency>
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="">
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.9.0-2.20574.26">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha />
<Sha>e9fd4dc7d74932c0d4b042251bc5a88bb5b3c437</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
6 changes: 4 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@
</PropertyGroup>
<!-- Toolset Dependencies -->
<PropertyGroup>
<DotNetCliVersion>3.1.100</DotNetCliVersion>
<MicrosoftNetCompilersToolsetVersion>3.3.1-beta3-final</MicrosoftNetCompilersToolsetVersion>
<!-- DotNetCliVersion MUST match the dotnet version in global.json.
Otherwise, this version of dotnet will not be installed and the build will error out. -->
<DotNetCliVersion>5.0.102</DotNetCliVersion>
<MicrosoftNetCompilersToolsetVersion>3.9.0-2.20574.26</MicrosoftNetCompilersToolsetVersion>
<NuGetBuildTasksVersion>5.9.0-preview.2.6979</NuGetBuildTasksVersion>
</PropertyGroup>
<Target Name="OverrideArcadeFileVersion" AfterTargets="_InitializeAssemblyVersion">
Expand Down
2 changes: 1 addition & 1 deletion eng/cibuild_bootstrapped_msbuild.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ try {
else
{
$buildToolPath = $dotnetExePath
$buildToolCommand = Join-Path $bootstrapRoot "netcoreapp2.1\MSBuild\MSBuild.dll"
$buildToolCommand = Join-Path $bootstrapRoot "net5.0\MSBuild\MSBuild.dll"
$buildToolFramework = "netcoreapp2.1"
}

Expand Down
2 changes: 1 addition & 1 deletion eng/cibuild_bootstrapped_msbuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ bootstrapRoot="$Stage1Dir/bin/bootstrap"
if [ $host_type = "core" ]
then
_InitializeBuildTool="$_InitializeDotNetCli/dotnet"
_InitializeBuildToolCommand="$bootstrapRoot/netcoreapp2.1/MSBuild/MSBuild.dll"
_InitializeBuildToolCommand="$bootstrapRoot/net5.0/MSBuild/MSBuild.dll"
_InitializeBuildToolFramework="netcoreapp2.1"
elif [ $host_type = "mono" ]
then
Expand Down
158 changes: 0 additions & 158 deletions eng/common/CheckSymbols.ps1

This file was deleted.

83 changes: 0 additions & 83 deletions eng/common/PublishToPackageFeed.proj

This file was deleted.

Loading