Proper support for multiline messages #9699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
Feb 1, 2024
...ts/Snapshots/TerminalLogger_Tests.PrintBuildSummary_SucceededWithWarnings.Linux.verified.txt
Outdated
Show resolved
Hide resolved
...ts/Snapshots/TerminalLogger_Tests.PrintBuildSummary_SucceededWithWarnings.Linux.verified.txt
Outdated
Show resolved
Hide resolved
|
Oh, just had a thought about moving the first line: @baronfel that would break the VS Code problem matcher, wouldn't it? |
|
Oof, you're right. We'd need to check and update those |
|
I checked the matcher regex and it doesn't (for example) support all combinations we have for line/column info. For example case when |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
As discussed offline, we will not wait for VSCode update. |
ladipro
approved these changes
Mar 20, 2024
baronfel
approved these changes
Mar 20, 2024
|
@MichalPavlik the diff is now showing 277 modified files. Something didn't go well with rebase/merge. |
|
I had to rebase to register this feature. I'm not sure what happened, but these additional changes should reflect current main. |
…ved project name from message line.
…he logic for appending a string to a `StringBuilder` object has been modified. The change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0. Changes: 1. In the `TerminalLogger` class, the logic for appending a string to a `StringBuilder` object has been updated. Previously, if `endLineNumber` was 0, a string formatted with `lineNumber` and `endColumnNumber` would be appended. Now, a string formatted with `lineNumber` and `columnNumber` is appended instead. This change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0.
Co-authored-by: Ladi Prosek <laprosek@microsoft.com>
…ved project name from message line.
…he logic for appending a string to a `StringBuilder` object has been modified. The change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0. Changes: 1. In the `TerminalLogger` class, the logic for appending a string to a `StringBuilder` object has been updated. Previously, if `endLineNumber` was 0, a string formatted with `lineNumber` and `endColumnNumber` would be appended. Now, a string formatted with `lineNumber` and `columnNumber` is appended instead. This change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0.
Co-authored-by: Ladi Prosek <laprosek@microsoft.com>
…_featureStatusMap` dictionary in the `Features` class. This feature, named `"TerminalLogger_MultiLineHandler"`, is set to `FeatureStatus.Available`, indicating that the TerminalLogger now has improved support for handling multi-line messages. List of Changes: 1. A new feature `"TerminalLogger_MultiLineHandler"` was added to the `_featureStatusMap` dictionary in the `Features` class within the `Microsoft.Build.Framework` namespace. This feature is set to `FeatureStatus.Available`, suggesting enhanced support for multi-line messages in TerminalLogger. Reference to Code Changes: - Addition of `"TerminalLogger_MultiLineHandler"` feature to `_featureStatusMap` dictionary in `Features` class.
MichalPavlik
force-pushed
the
dev/mipavlik/terminallogger-multiline-messages
branch
from
8db59d9
to
9b6e5ae
Compare
|
I reconstructed commit stream on top of main, but it looks like I'm removing Jakub's changes for some reason.... |
ladipro
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9666
Context
Adding proper support for multiline messages (with indentation).
Removed project name from message line.
Changes Made
Terminal logger uses different parsing and rendering.
Testing
Unit tests were updated + manual testing (Windows)
Notes
New output: