Proper support for multiline messages #9699
Merged
Commits on Mar 21, 2024
-
Adding proper support for multiline messages (with indentation). Remo…
…ved project name from message line.
-
-
-
-
-
-
-
The most significant change is in the
TerminalLoggerclass, where t……he logic for appending a string to a `StringBuilder` object has been modified. The change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0. Changes: 1. In the `TerminalLogger` class, the logic for appending a string to a `StringBuilder` object has been updated. Previously, if `endLineNumber` was 0, a string formatted with `lineNumber` and `endColumnNumber` would be appended. Now, a string formatted with `lineNumber` and `columnNumber` is appended instead. This change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0.
-
Update src/MSBuild/TerminalLogger/TerminalLogger.cs
Co-authored-by: Ladi Prosek <laprosek@microsoft.com>
-
Adding proper support for multiline messages (with indentation). Remo…
…ved project name from message line.
-
-
-
-
-
-
-
The most significant change is in the
TerminalLoggerclass, where t……he logic for appending a string to a `StringBuilder` object has been modified. The change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0. Changes: 1. In the `TerminalLogger` class, the logic for appending a string to a `StringBuilder` object has been updated. Previously, if `endLineNumber` was 0, a string formatted with `lineNumber` and `endColumnNumber` would be appended. Now, a string formatted with `lineNumber` and `columnNumber` is appended instead. This change corrects a potential issue where `endColumnNumber` was being used instead of `columnNumber` when `endLineNumber` is 0.
-
Update src/MSBuild/TerminalLogger/TerminalLogger.cs
Co-authored-by: Ladi Prosek <laprosek@microsoft.com>
-
The most significant change is the addition of a new feature to the `…
…_featureStatusMap` dictionary in the `Features` class. This feature, named `"TerminalLogger_MultiLineHandler"`, is set to `FeatureStatus.Available`, indicating that the TerminalLogger now has improved support for handling multi-line messages. List of Changes: 1. A new feature `"TerminalLogger_MultiLineHandler"` was added to the `_featureStatusMap` dictionary in the `Features` class within the `Microsoft.Build.Framework` namespace. This feature is set to `FeatureStatus.Available`, suggesting enhanced support for multi-line messages in TerminalLogger. Reference to Code Changes: - Addition of `"TerminalLogger_MultiLineHandler"` feature to `_featureStatusMap` dictionary in `Features` class.
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.