Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohost Go To Definition does not map Html URIs #10823

Closed
davidwengier opened this issue Sep 3, 2024 · 0 comments · Fixed by #10826
Closed

Cohost Go To Definition does not map Html URIs #10823

davidwengier opened this issue Sep 3, 2024 · 0 comments · Fixed by #10826
Assignees
Milestone

Comments

@davidwengier
Copy link
Contributor

When the Html language server returns results in the Go To Definition endpoint in Cohosting, the Uris it returns need to be checked and potentially remapped from __virtual.html Uris back to the .razor/.cshtml Uris they originated from.

This code:
https://github.com/dotnet/razor/blob/main/src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostGoToDefinitionEndpoint.cs#L116

Needs to do a little more of this:
https://github.com/dotnet/razor/blob/main/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Definition/DefinitionEndpoint.cs#L101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant