Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remap Html uris in cohost Go To Def #10826

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Remap Html uris in cohost Go To Def #10826

merged 3 commits into from
Sep 4, 2024

Conversation

davidwengier
Copy link
Contributor

Fixes #10823

@davidwengier davidwengier requested a review from a team as a code owner September 3, 2024 06:58
DustinCampbell
DustinCampbell approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I'm delighted for you to clean up bits that I missed. 😄

...icrosoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostGoToDefinitionEndpointTest.cs Outdated Show resolved Hide resolved
...icrosoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostGoToDefinitionEndpointTest.cs Outdated Show resolved Hide resolved
...icrosoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostGoToDefinitionEndpointTest.cs Outdated Show resolved Hide resolved
...icrosoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostGoToDefinitionEndpointTest.cs Show resolved Hide resolved
@davidwengier davidwengier merged commit 915c4c3 into dotnet:main Sep 4, 2024
12 checks passed
@davidwengier davidwengier deleted the FixCohostGoToDef branch September 4, 2024 01:32
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 4, 2024
This was referenced Sep 6, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Sep 14, 2024
Closed
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.12 P3 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryamariyan maryamariyan maryamariyan approved these changes

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.12 P3
Development

Successfully merging this pull request may close these issues.

Cohost Go To Definition does not map Html URIs
4 participants
@davidwengier @DustinCampbell @maryamariyan @phil-allen-msft