Add latest .NET 8 runtime to global.json #10659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we updated to a .NET 9 SDK, the MS.ANC.Razor.Microbenchmarks.Generator unit tests have failed to run locally. This is because these test use Benchmark.NET, which performs a builder at runtime targeting .NET 8. This works fine in CI because it uses a .NET 8 SDK. This change just adds the most recent .NET 8 runtime version to the list of runtimes in Razor's global.json. So, it'll get installed into the .dotnet folder and the Microbenchmarks.Generator will run and stop reporting a spurious error.
chsienki
approved these changes
Jul 22, 2024
jjonescz
reviewed
Jul 22, 2024
| @@ -5,7 +5,8 @@ | |||
| "dotnet": [ | |||
| "2.1.30", | |||
| "$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)", | |||
| "3.1.30" | |||
| "3.1.30", | |||
| "8.0.7" | |||
There was a problem hiding this comment.
I'm wondering if this is needed then 9e8dbcc or if the correct runtime will be installed in CI as well?
There was a problem hiding this comment.
I imagine it isn't needed.
There was a problem hiding this comment.
I'll try removing it and see if CI passes with this global.json tweak.
There was a problem hiding this comment.
@jjonescz: It looks like you were right. This is no longer needed.
333fred
approved these changes
Jul 22, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we updated to a .NET 9 SDK, the
MS.ANC.Razor.Microbenchmarks.Generator unit tests have failed to run locally. This is because these test use Benchmark.NET, which performs a builder at runtime targeting .NET 8. This works fine in CI because it uses a .NET 8 SDK.
This change just adds the most recent .NET 8 runtime version to the list of runtimes in Razor's global.json. So, it'll get installed into the .dotnet folder and the Microbenchmarks.Generator will run and stop reporting a spurious error.