Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latest .NET 8 runtime to global.json #10659

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add latest .NET 8 runtime to global.json #10659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c93ab14
Add latest .NET 8 runtime to global.json
DustinCampbell Jul 22, 2024
f3bf643
Remove Azure pipeline task to install .NET 8 runtime
DustinCampbell Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,6 @@ stages:
displayName: Build and Deploy
condition: succeeded()

# Needed for Microsoft.AspNetCore.Razor.Microbenchmarks.Generator tests
- task: UseDotNet@2
displayName: 'Install .NET 8 runtime'
inputs:
packageType: runtime
version: 8.x
installationPath: '$(Build.SourcesDirectory)\.dotnet'

- script: eng\CIBuild.cmd
-configuration $(_BuildConfig)
-prepareMachine
Expand Down
3 changes: 2 additions & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"dotnet": [
"2.1.30",
"$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)",
"3.1.30"
"3.1.30",
"8.0.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this is needed then 9e8dbcc or if the correct runtime will be installed in CI as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine it isn't needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try removing it and see if CI passes with this global.json tweak.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjonescz: It looks like you were right. This is no longer needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the better fix!

]
},
"vs": {
Expand Down
Loading