Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate delegated completion list resolver tests to use C# server. #6624

Merged
1 commit merged into from
Jul 22, 2022

Conversation

NTaylorMullen
Copy link
Contributor

  • Updated C# portions of our delegated completion list provider tests to utilze the real C# server and simplified the testing model.
  • Maintained a lot of pre-existing tests because we don't have similar capabilities for HTML
  • These tests will be more widely used upon completion of TextEdit resolution does not work in single server completion #6618 where we'll want to resolve text edits (this is a leadup).

Part of #6618

Copy link
Contributor

@allisonchou allisonchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for test improvements 🎉

Base automatically changed from nimullen/completionlisttests to main July 22, 2022 20:02
- Updated C# portions of our delegated completion list provider tests to utilze the real C# server and simplified the testing model.
- Maintained a lot of pre-existing tests because we don't have similar capabilities for HTML
- These tests will be more widely used upon completion of #6618 where we'll want to resolve text edits (this is a leadup).

Part of #6618
@NTaylorMullen NTaylorMullen force-pushed the nimullen/completionresolvetests branch from 8edd089 to 501f5b1 Compare July 22, 2022 20:03
@NTaylorMullen NTaylorMullen added the auto-merge Squash merge once all PR checks are complete and reviewers have approved label Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Hello @NTaylorMullen!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2a62139 into main Jul 22, 2022
@ghost ghost deleted the nimullen/completionresolvetests branch July 22, 2022 20:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Squash merge once all PR checks are complete and reviewers have approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants