TextEdit resolution does not work in single server completion #6618

NTaylorMullen · 2022-07-21T17:05:08Z

This represents trying to complete C# override statements and the await keyword.

The text was updated successfully, but these errors were encountered:

- Updated C# portions of our delegated completion list provider tests to utilze the real C# server and simplified the testing model. - Maintained a lot of pre-existing tests because we don't have similar capabilities for HTML - These tests will be more widely used upon completion of #6618 where we'll want to resolve text edits (this is a leadup). Part of #6618

- Prior to this C# snippets were wrapped/unwrapped at the endpoint layer. This means anyone trying to format a snippet would need to manually wrap/unwrap their own snippets. The logic fit well into the existing formatting service so I migrated the logic there. - Another aspect of this that's a little disconnected is that when applying formatted snippet edits I found that edits wouldn't get "minimialized" prior to collapsing which would result in unminified edits returning to the client. At completion time (what I will eventually be doing as part of #6618) this was highly troublesome because completion is sensitive to the "end of the edit" area. Meaning if you complete `await` and the await has a complex text edit that gets formatted the `t` in `await` needs to be the absolute last thing in the edit to not obstruct the cursor; however, without the minimal edit change that doesn't actually work properly. I imagine this was just an unintentional oversight and wasn't quite sure how to test this (although I do test it in the completion resolve tests that are coming latere) so I included it here. - Currently there's no direct tests of this method it looks like. Although in a follow up PR for #6618 I'll be formatting resolved completion items. Part of #6618

- Updated C# portions of our delegated completion list provider tests to utilze the real C# server and simplified the testing model. - Maintained a lot of pre-existing tests because we don't have similar capabilities for HTML - These tests will be more widely used upon completion of #6618 where we'll want to resolve text edits (this is a leadup). Part of #6618

- Prior to this C# snippets were wrapped/unwrapped at the endpoint layer. This means anyone trying to format a snippet would need to manually wrap/unwrap their own snippets. The logic fit well into the existing formatting service so I migrated the logic there. - Another aspect of this that's a little disconnected is that when applying formatted snippet edits I found that edits wouldn't get "minimialized" prior to collapsing which would result in unminified edits returning to the client. At completion time (what I will eventually be doing as part of #6618) this was highly troublesome because completion is sensitive to the "end of the edit" area. Meaning if you complete `await` and the await has a complex text edit that gets formatted the `t` in `await` needs to be the absolute last thing in the edit to not obstruct the cursor; however, without the minimal edit change that doesn't actually work properly. I imagine this was just an unintentional oversight and wasn't quite sure how to test this (although I do test it in the completion resolve tests that are coming latere) so I included it here. - Currently there's no direct tests of this method it looks like. Although in a follow up PR for #6618 I'll be formatting resolved completion items. Part of #6618

…time. - Migrated our old `CompletionResolutionHandler` logic for post-processing C# completion items to our new single server completion system. - One current gap is that the old system used to lookup active formatting options on the client to understand if snippets should be formatted with/without tabs etc. For now I'm using defaults but in a follow up PR i'll light up the real formatting options acquisition logic. - As part of this PR there were several pieces of code that could be re-used so I refactored them out. The `TestRazorFormattingService` is a prime example (especially now that completion resolve depends on it). - Did a few updates to the API so it was clear what type of formatting service you'd be getting (aka should it be HTML enabled?). - Added a test that validates that we get and remap text edit completions properly (I use `await`). I couldn't find a corresponding C# completion item that utilizes `AdditionalTextEdit`s. ## Enables ![gif of await and override completion working](https://i.imgur.com/EAwqM3j.gif) Most of #6618

- This is the final part to #6618 to enable completion resolve to acquire formatting options for complex text edits so it can properly format text edits - We now expose a new endpoint on the client under `razor/formatting/options` that will return the most recent understanding of formatting options - To make this possible updated the `FormattingOptionsProvider` API to take a `Uri` instead of a document snapshot. - Updated tests accordingly Final part of #6618

…6624) - Updated C# portions of our delegated completion list provider tests to utilze the real C# server and simplified the testing model. - Maintained a lot of pre-existing tests because we don't have similar capabilities for HTML - These tests will be more widely used upon completion of #6618 where we'll want to resolve text edits (this is a leadup). Part of #6618

- The original `CSharp_Operator_Triggered` test was an incorrect scenario. For instance, C# doesn't typically trigger completions off of typing `(`. Instead I migrated the test to do a `DateTime.` variant with `.` being the trigger. The only catch then was that our generated C# document did not contain `using System` so I had to update our generated code document bits to properly generate the using statement. Part of #6618

- Prior to this C# snippets were wrapped/unwrapped at the endpoint layer. This means anyone trying to format a snippet would need to manually wrap/unwrap their own snippets. The logic fit well into the existing formatting service so I migrated the logic there. - Another aspect of this that's a little disconnected is that when applying formatted snippet edits I found that edits wouldn't get "minimialized" prior to collapsing which would result in unminified edits returning to the client. At completion time (what I will eventually be doing as part of #6618) this was highly troublesome because completion is sensitive to the "end of the edit" area. Meaning if you complete `await` and the await has a complex text edit that gets formatted the `t` in `await` needs to be the absolute last thing in the edit to not obstruct the cursor; however, without the minimal edit change that doesn't actually work properly. I imagine this was just an unintentional oversight and wasn't quite sure how to test this (although I do test it in the completion resolve tests that are coming latere) so I included it here. - Currently there's no direct tests of this method it looks like. Although in a follow up PR for #6618 I'll be formatting resolved completion items. Part of #6618

…time. - Migrated our old `CompletionResolutionHandler` logic for post-processing C# completion items to our new single server completion system. - One current gap is that the old system used to lookup active formatting options on the client to understand if snippets should be formatted with/without tabs etc. For now I'm using defaults but in a follow up PR i'll light up the real formatting options acquisition logic. - As part of this PR there were several pieces of code that could be re-used so I refactored them out. The `TestRazorFormattingService` is a prime example (especially now that completion resolve depends on it). - Did a few updates to the API so it was clear what type of formatting service you'd be getting (aka should it be HTML enabled?). - Added a test that validates that we get and remap text edit completions properly (I use `await`). I couldn't find a corresponding C# completion item that utilizes `AdditionalTextEdit`s. ## Enables ![gif of await and override completion working](https://i.imgur.com/EAwqM3j.gif) Most of #6618

- This is the final part to #6618 to enable completion resolve to acquire formatting options for complex text edits so it can properly format text edits - We now expose a new endpoint on the client under `razor/formatting/options` that will return the most recent understanding of formatting options - To make this possible updated the `FormattingOptionsProvider` API to take a `Uri` instead of a document snapshot. - Updated tests accordingly Final part of #6618

- The original `CSharp_Operator_Triggered` test was an incorrect scenario. For instance, C# doesn't typically trigger completions off of typing `(`. Instead I migrated the test to do a `DateTime.` variant with `.` being the trigger. The only catch then was that our generated C# document did not contain `using System` so I had to update our generated code document bits to properly generate the using statement. Part of #6618

…time. (#6626) * Add support for remapping TextEdits & AdditionalTextEdits at resolve time. - Migrated our old `CompletionResolutionHandler` logic for post-processing C# completion items to our new single server completion system. - One current gap is that the old system used to lookup active formatting options on the client to understand if snippets should be formatted with/without tabs etc. For now I'm using defaults but in a follow up PR i'll light up the real formatting options acquisition logic. - As part of this PR there were several pieces of code that could be re-used so I refactored them out. The `TestRazorFormattingService` is a prime example (especially now that completion resolve depends on it). - Did a few updates to the API so it was clear what type of formatting service you'd be getting (aka should it be HTML enabled?). - Added a test that validates that we get and remap text edit completions properly (I use `await`). I couldn't find a corresponding C# completion item that utilizes `AdditionalTextEdit`s. ## Enables ![gif of await and override completion working](https://i.imgur.com/EAwqM3j.gif) Most of #6618 * Address code review comments.

- This is the final part to #6618 to enable completion resolve to acquire formatting options for complex text edits so it can properly format text edits - We now expose a new endpoint on the client under `razor/formatting/options` that will return the most recent understanding of formatting options - To make this possible updated the `FormattingOptionsProvider` API to take a `Uri` instead of a document snapshot. - Updated tests accordingly Final part of #6618

- Prior to this C# snippets were wrapped/unwrapped at the endpoint layer. This means anyone trying to format a snippet would need to manually wrap/unwrap their own snippets. The logic fit well into the existing formatting service so I migrated the logic there. - Another aspect of this that's a little disconnected is that when applying formatted snippet edits I found that edits wouldn't get "minimialized" prior to collapsing which would result in unminified edits returning to the client. At completion time (what I will eventually be doing as part of #6618) this was highly troublesome because completion is sensitive to the "end of the edit" area. Meaning if you complete `await` and the await has a complex text edit that gets formatted the `t` in `await` needs to be the absolute last thing in the edit to not obstruct the cursor; however, without the minimal edit change that doesn't actually work properly. I imagine this was just an unintentional oversight and wasn't quite sure how to test this (although I do test it in the completion resolve tests that are coming latere) so I included it here. - Currently there's no direct tests of this method it looks like. Although in a follow up PR for #6618 I'll be formatting resolved completion items. Part of #6618

…time. (#6626) * Add support for remapping TextEdits & AdditionalTextEdits at resolve time. - Migrated our old `CompletionResolutionHandler` logic for post-processing C# completion items to our new single server completion system. - One current gap is that the old system used to lookup active formatting options on the client to understand if snippets should be formatted with/without tabs etc. For now I'm using defaults but in a follow up PR i'll light up the real formatting options acquisition logic. - As part of this PR there were several pieces of code that could be re-used so I refactored them out. The `TestRazorFormattingService` is a prime example (especially now that completion resolve depends on it). - Did a few updates to the API so it was clear what type of formatting service you'd be getting (aka should it be HTML enabled?). - Added a test that validates that we get and remap text edit completions properly (I use `await`). I couldn't find a corresponding C# completion item that utilizes `AdditionalTextEdit`s. ## Enables ![gif of await and override completion working](https://i.imgur.com/EAwqM3j.gif) Most of #6618 * Address code review comments.

- This is the final part to #6618 to enable completion resolve to acquire formatting options for complex text edits so it can properly format text edits - We now expose a new endpoint on the client under `razor/formatting/options` that will return the most recent understanding of formatting options - To make this possible updated the `FormattingOptionsProvider` API to take a `Uri` instead of a document snapshot. - Updated tests accordingly Final part of #6618

NTaylorMullen added the bug Something isn't working label Jul 21, 2022

NTaylorMullen added this to the 17.4-Preview1 CC:~7/25 milestone Jul 21, 2022

NTaylorMullen self-assigned this Jul 21, 2022

mikadumont added the user story label Jul 21, 2022

NTaylorMullen mentioned this issue Jul 22, 2022

Migrate delegated completion list resolver tests to use C# server. #6624

Merged

NTaylorMullen mentioned this issue Jul 22, 2022

Fix FormatSnippetAsync to properly format C# snippets. #6625

Merged

NTaylorMullen mentioned this issue Jul 22, 2022

Add support for remapping TextEdits & AdditionalTextEdits at resolve time. #6626

Merged

NTaylorMullen mentioned this issue Jul 22, 2022

Add support for acquiring formatting options from client. #6627

Merged

NTaylorMullen mentioned this issue Jul 22, 2022

Unskip completion list provider test. #6628

Merged

NTaylorMullen closed this as completed Jul 25, 2022

ghost locked as resolved and limited conversation to collaborators Aug 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TextEdit resolution does not work in single server completion #6618

TextEdit resolution does not work in single server completion #6618

NTaylorMullen commented Jul 21, 2022

TextEdit resolution does not work in single server completion #6618

TextEdit resolution does not work in single server completion #6618

Comments

NTaylorMullen commented Jul 21, 2022