Add support for remapping TextEdits & AdditionalTextEdits at resolve time. #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
requested review from
a team,
ryanbrandenburg,
allisonchou,
sharwell and
davidwengier
as code owners
NTaylorMullen
force-pushed
the
nimullen/6618.formattingservicesnippets
branch
from
c485c34
to
80eb1eb
Compare
…time.
- Migrated our old `CompletionResolutionHandler` logic for post-processing C# completion items to our new single server completion system.
- One current gap is that the old system used to lookup active formatting options on the client to understand if snippets should be formatted with/without tabs etc. For now I'm using defaults but in a follow up PR i'll light up the real formatting options acquisition logic.
- As part of this PR there were several pieces of code that could be re-used so I refactored them out. The `TestRazorFormattingService` is a prime example (especially now that completion resolve depends on it).
- Did a few updates to the API so it was clear what type of formatting service you'd be getting (aka should it be HTML enabled?).
- Added a test that validates that we get and remap text edit completions properly (I use `await`). I couldn't find a corresponding C# completion item that utilizes `AdditionalTextEdit`s.
## Enables
Most of #6618
NTaylorMullen
force-pushed
the
nimullen/6618.resolve
branch
from
5e5db5f
to
f8041b9
Compare
allisonchou
approved these changes
Jul 22, 2022
...test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting/TestRazorFormattingService.cs
Outdated
Show resolved
Hide resolved
davidwengier
approved these changes
Jul 25, 2022
NTaylorMullen
added a commit
that referenced
this pull request
Jul 25, 2022
…time. (#6626) * Add support for remapping TextEdits & AdditionalTextEdits at resolve time. - Migrated our old `CompletionResolutionHandler` logic for post-processing C# completion items to our new single server completion system. - One current gap is that the old system used to lookup active formatting options on the client to understand if snippets should be formatted with/without tabs etc. For now I'm using defaults but in a follow up PR i'll light up the real formatting options acquisition logic. - As part of this PR there were several pieces of code that could be re-used so I refactored them out. The `TestRazorFormattingService` is a prime example (especially now that completion resolve depends on it). - Did a few updates to the API so it was clear what type of formatting service you'd be getting (aka should it be HTML enabled?). - Added a test that validates that we get and remap text edit completions properly (I use `await`). I couldn't find a corresponding C# completion item that utilizes `AdditionalTextEdit`s. ## Enables  Most of #6618 * Address code review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompletionResolutionHandlerlogic for post-processing C# completion items to our new single server completion system.TestRazorFormattingServiceis a prime example (especially now that completion resolve depends on it).await). I couldn't find a corresponding C# completion item that utilizesAdditionalTextEdits.Enables
Most of #6618