Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remapping TextEdits & AdditionalTextEdits at resolve time. #6626

Merged

Commits on Jul 22, 2022

  1. Add support for remapping TextEdits & AdditionalTextEdits at resolve …

    …time.
    
    - Migrated our old `CompletionResolutionHandler` logic for post-processing C# completion items to our new single server completion system.
        - One current gap is that the old system used to lookup active formatting options on the client to understand if snippets should be formatted with/without tabs etc. For now I'm using defaults but in a follow up PR i'll light up the real formatting options acquisition logic.
    - As part of this PR there were several pieces of code that could be re-used so I refactored them out. The `TestRazorFormattingService` is a prime example (especially now that completion resolve depends on it).
        - Did a few updates to the API so it was clear what type of formatting service you'd be getting (aka should it be HTML enabled?).
    - Added a test that validates that we get and remap text edit completions properly (I use `await`). I couldn't find a corresponding C# completion item that utilizes `AdditionalTextEdit`s.
    
    ## Enables
    
    ![gif of await and override completion working](https://i.imgur.com/EAwqM3j.gif)
    
    Most of #6618
    NTaylorMullen committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    f8041b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bce48c2 View commit details
    Browse the repository at this point in the history