Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to improve code fixer heuristic employed by CA1835 #4269

Merged
merged 13 commits into from
Oct 3, 2020
Merged

Fix to improve code fixer heuristic employed by CA1835 #4269

merged 13 commits into from
Oct 3, 2020

Commits on Oct 1, 2020

  1. Shared Fixer: detect arguments 0 and buffer.Length.

    @carlossanlop
    carlossanlop committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    87796c9 View commit details
    Browse the repository at this point in the history

  2. CSharp fixer: Implement method that detects 0 and buffer.Length synta… 

    …x nodes.
    @carlossanlop
    carlossanlop committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    724522e View commit details
    Browse the repository at this point in the history

  3. VB fixer: Implement method that detects 0 and buffer.Length syntax no… 

    …des.
    @carlossanlop
    carlossanlop committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    c89194a View commit details
    Browse the repository at this point in the history

  4. Test data: 

    Add new test cases to handle partial buffer read/write.

Adjust existing test cases that use the full buffer to avoid adding the AsMemory invocation.
    @carlossanlop
    carlossanlop committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    4a75e45 View commit details
    Browse the repository at this point in the history

  5. ReadAsync tests: Consume the new test data.

    @carlossanlop
    carlossanlop committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    7618523 View commit details
    Browse the repository at this point in the history

  6. WriteAsync tests: Consume the new test data.

    @carlossanlop
    carlossanlop committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b5082bf View commit details
    Browse the repository at this point in the history

  7. Suggestions by Evangelink.

    @carlossanlop
    carlossanlop committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    0e5452a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Pass the semantic model to the syntax-specific method.

    @carlossanlop
    carlossanlop committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    60a0625 View commit details
    Browse the repository at this point in the history

  2. Adapt the C# syntax-specific method to take the semantic model instance.

    @carlossanlop
    carlossanlop committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    04a1b40 View commit details
    Browse the repository at this point in the history

  3. Adapt the VB syntax-specific method to take the semantic model instance.

    @carlossanlop
    carlossanlop committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    5aed494 View commit details
    Browse the repository at this point in the history

  4. Fix some failing new test cases.

    @carlossanlop
    carlossanlop committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    5ee28f9 View commit details
    Browse the repository at this point in the history

  5. Update the unit tests.

    @carlossanlop
    carlossanlop committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    c69af85 View commit details
    Browse the repository at this point in the history

  6. Simplify check for 0 by directly using the constant pattern check on … 

    …the Value without having to cast to integer first.

Use existing WellKnownMemberName instead "Length".
    @carlossanlop
    carlossanlop committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    af4ec1c View commit details
    Browse the repository at this point in the history