Fix to improve code fixer heuristic employed by CA1835 #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new test cases to handle partial buffer read/write. Adjust existing test cases that use the full buffer to avoid adding the AsMemory invocation.
carlossanlop
requested review from
stephentoub,
pgovind,
mavasani,
jozkee and
buyaa-n
carlossanlop
commented
Oct 1, 2020
...s/CSharp/Microsoft.NetCore.Analyzers/Runtime/CSharpPreferStreamAsyncMemoryOverloads.Fixer.cs
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Oct 1, 2020
...s/CSharp/Microsoft.NetCore.Analyzers/Runtime/CSharpPreferStreamAsyncMemoryOverloads.Fixer.cs
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Evangelink
reviewed
Oct 1, 2020
...Analyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.Fixer.cs
Outdated
Show resolved
Hide resolved
...Analyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.Fixer.cs
Outdated
Show resolved
Hide resolved
...Analyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.Fixer.cs
Outdated
Show resolved
Hide resolved
...Analyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.Fixer.cs
Outdated
Show resolved
Hide resolved
...sualBasic/Microsoft.NetCore.Analyzers/Runtime/BasicPreferStreamAsyncMemoryOverloads.Fixer.vb
Outdated
Show resolved
Hide resolved
...sualBasic/Microsoft.NetCore.Analyzers/Runtime/BasicPreferStreamAsyncMemoryOverloads.Fixer.vb
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Oct 1, 2020
...sualBasic/Microsoft.NetCore.Analyzers/Runtime/BasicPreferStreamAsyncMemoryOverloads.Fixer.vb
Outdated
Show resolved
Hide resolved
mavasani
approved these changes
Oct 1, 2020
|
FYI I opened a proposal to suggest simplifying Edit: I moved it to the roslyn repo: dotnet/roslyn#48239 |
Youssef1313
reviewed
Oct 2, 2020
...s/CSharp/Microsoft.NetCore.Analyzers/Runtime/CSharpPreferStreamAsyncMemoryOverloads.Fixer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Oct 2, 2020
...s/CSharp/Microsoft.NetCore.Analyzers/Runtime/CSharpPreferStreamAsyncMemoryOverloads.Fixer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Oct 2, 2020
...sualBasic/Microsoft.NetCore.Analyzers/Runtime/BasicPreferStreamAsyncMemoryOverloads.Fixer.vb
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Oct 2, 2020
...sualBasic/Microsoft.NetCore.Analyzers/Runtime/BasicPreferStreamAsyncMemoryOverloads.Fixer.vb
Show resolved
Hide resolved
…the Value without having to cast to integer first. Use existing WellKnownMemberName instead "Length".
|
Thanks for improving this. |
Evangelink
pushed a commit
to Evangelink/roslyn-analyzers
that referenced
this pull request
Oct 12, 2020
* Shared Fixer: detect arguments 0 and buffer.Length. * CSharp fixer: Implement method that detects 0 and buffer.Length syntax nodes. * VB fixer: Implement method that detects 0 and buffer.Length syntax nodes. * Test data: Add new test cases to handle partial buffer read/write. Adjust existing test cases that use the full buffer to avoid adding the AsMemory invocation. * ReadAsync tests: Consume the new test data. * WriteAsync tests: Consume the new test data. * Suggestions by Evangelink. * Pass the semantic model to the syntax-specific method. * Adapt the C# syntax-specific method to take the semantic model instance. * Adapt the VB syntax-specific method to take the semantic model instance. * Fix some failing new test cases. * Update the unit tests. * Simplify check for 0 by directly using the constant pattern check on the Value without having to cast to integer first. Use existing WellKnownMemberName instead "Length". Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4235
For invocations of ReadAsync/WriteAsync that consider the full buffer (from
0tobuffer.Length):Instead of suggesting this:
We now want to suggest this: