CA1416 Fix Version comparison ambiguity #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/5.0.3xx #5079 +/- ##
===================================================
- Coverage 95.82% 95.82% -0.01%
===================================================
Files 1164 1165 +1
Lines 264739 264851 +112
Branches 15993 16005 +12
===================================================
+ Hits 253698 253792 +94
- Misses 9022 9027 +5
- Partials 2019 2032 +13 |
jeffhandley
approved these changes
Apr 29, 2021
buyaa-n
added a commit
that referenced
this pull request
May 11, 2021
* Add localization from OneLocBuild (2021-04-27) * Merge conflicts (#5079) * Add localization from OneLocBuild (2021-04-28) Co-authored-by: Jon Fortescue <jonfortescue@protonmail.com> Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com> Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com> Co-authored-by: Jonathon Marolf <jmarolf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: #4932
Port of #4943
The comparison of versions having leading 0 causing CA1416 malfunction
Context:
The comparison operations of the Version type is a bit strange:
Console.WriteLine(Version.Parse("10.0.17763.0") < Version.Parse("10.0.17763")); // False
Console.WriteLine(Version.Parse("10.0.17763.0") > Version.Parse("10.0.17763")); // True
Console.WriteLine(Version.Parse("10.0.17763.0") == Version.Parse("10.0.17763")); // False
The WinRT team wants the fix serviced in 5.0
Risk:
No risk of causing new warnings instead suppresses warnings caused from leading 0 like above.
CC @jeffhandley @jmarolf @marcpopMSFT @mavasani