Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA1839: Avoid const arrays [NO MERGE] #5379

Closed
wants to merge 368 commits into from
Closed

CA1839: Avoid const arrays [NO MERGE] #5379

wants to merge 368 commits into from

Conversation

steveberdy
Copy link
Contributor

@steveberdy steveberdy commented Aug 16, 2021 •
edited
Loading

CA1839: Avoid const arrays

See #5383

NewellClark and others added 30 commits February 27, 2021 10:56
@NewellClark
Merge branch 'release/6.0.1xx-preview2' into use-CancellationToken-Th…
d16627f 
…rowIfCancellationRequested
@mavasani
Merge pull request #4887 from dotnet/merges/master-to-release/6.0.1xx…
dea6979 
…-preview3

Merge master to release/6.0.1xx-preview3
@jmarolf
Merge branch 'release/6.0.1xx-preview2' into merges/release/6.0.1xx-p…
e6a7324 
…review1-to-release/6.0.1xx-preview2
@jmarolf
Merge pull request #4924 from dotnet/merges/master-to-release/6.0.1xx…
c054652 
…-preview3
@stephentoub
Add analyzers/fixers for Environment.ProcessPath and CurrentManagedTh…
940c426 
…readId (#4909)

* Add analyzers/fixers for Environment.ProcessPath and CurrentManagedThreadId

* Address PR feedback
@jmarolf
Merge pull request #4867 from dotnet/merges/release/6.0.1xx-preview1-…
eefe897 
…to-release/6.0.1xx-preview2
@dotnet-bot
Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3 (#4902)
8eb850e 
* CA-1418 Validate platform string (#4838)
@buyaa-n
Merge remote-tracking branch 'dotnet/release/6.0.1xx-preview2' into m…
df5ddc4 
…erges/release/6.0.1xx-preview2-to-release/6.0.1xx-preview3
@buyaa-n
OSX is alias for MacOS (#4952)
988eaf5 
* OSX is alias for MacOS
@jmarolf
Update Versions.props
5abaa41
@mmitche
Merge pull request #4951 from dotnet/merges/release/6.0.1xx-preview2-…
262ddfd 
…to-release/6.0.1xx-preview3

Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3
@mavasani
Merge pull request #4987 from dotnet/merges/release/6.0.1xx-preview3-…
2dda3d3 
…to-release/6.0.1xx-preview4

Merge release/6.0.1xx-preview3 to release/6.0.1xx-preview4
@mavasani
Merge pull request #4949 from dotnet/merges/release/6.0.1xx-preview1-…
e46220a 
…to-release/6.0.1xx-preview2

Merge release/6.0.1xx-preview1 to release/6.0.1xx-preview2
@buyaa-n
Remove unsupported attribute when allow deny list mixed (#5000)
1dcfb32
@jmarolf
Merge pull request #5004 from dotnet/merges/release/6.0.1xx-preview2-…
43dfa18 
…to-release/6.0.1xx-preview3

Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3
@jmarolf
Merge remote-tracking branch 'upstream/main' into merges/main-to-rele…
04c867f 
…ase/6.0.1xx-preview4
@jmarolf
Merge pull request #4976 from dotnet/merges/main-to-release/6.0.1xx-p…
e112315 
…review4

Merge main to release/6.0.1xx-preview4
@jmarolf
Merge pull request #5010 from dotnet/merges/release/6.0.1xx-preview3-…
6c23dc8 
…to-release/6.0.1xx-preview4

Merge release/6.0.1xx-preview3 to release/6.0.1xx-preview4
@jmarolf
Merge pull request #5015 from dotnet/merges/main-to-release/6.0.1xx-p…
86b88db 
…review4

Merge main to release/6.0.1xx-preview4
@buyaa-n
OSX needs to treated as the same platform as MacOS, everywhere (#5012)
135e126 
* OSX same as MacOS, need to treated as same everywhere
@mavasani
Merge pull request #5017 from dotnet/merges/main-to-release/6.0.1xx-p…
be17383 
…review4

Merge main to release/6.0.1xx-preview4
@mavasani
Merge branch 'release/6.0.1xx-preview4' into merges/main-to-release/6…
acf8240 
….0.1xx-preview4
@mavasani
Merge pull request #5018 from dotnet/merges/main-to-release/6.0.1xx-p…
e30830b 
…review4

Merge main to release/6.0.1xx-preview4
@jmarolf
Merge pull request #5019 from dotnet/merges/main-to-release/6.0.1xx-p…
a513416 
…review4

Merge main to release/6.0.1xx-preview4
@mavasani
Merge pull request #5020 from dotnet/merges/main-to-release/6.0.1xx-p…
d993fd4 
…review4

Merge main to release/6.0.1xx-preview4
@mavasani
Merge branch 'release/6.0.1xx-preview4' into merges/main-to-release/6…
ee92c7f 
….0.1xx-preview4
@jmarolf
Merge pull request #5022 from dotnet/merges/main-to-release/6.0.1xx-p…
157932f 
…review4

Merge main to release/6.0.1xx-preview4
@jmarolf
Update Versions.props
1b1660d
@ryzngard
Add CSharp analyzer and tests
d8512c8
@ryzngard
Add VB analyzer and tests
accfc0e
jmarolf and others added 26 commits August 17, 2021 16:47
@jmarolf @steveberdy
fixing formatting
4fe999d
@jmarolf @steveberdy
update headers
23ae553
@jmarolf @steveberdy
use preview language version
77cb72a
@jmarolf @steveberdy
prefer is not null to is object
abe363c
@jmarolf @steveberdy
fixup rebase
b87a9f3
@steveberdy
Update license headers in analyzer and tests
0947751
@crummel @steveberdy
Remove half-checked-in submodule.
e8f8f70
@steveberdy
Added comments and more unit tests
5eaffda
@steveberdy
Update csharp unit tests for analyzer
9b36c18
@steveberdy
Drafted code fixer and added unit tests
790f06b
@steveberdy
Update VerifyCS and VerifyVB aliases to include the fixer class
c3a4cff
@steveberdy
Update code fix tests
0ef4bec
@steveberdy
Update VB test code
d6eb2f7
@steveberdy
Clean up extract method
73d9891
@steveberdy
Refactored ISymbol.GetContainingMethod as an extension method
a19dc91
@steveberdy
Refactored extraction call
e331702
@get-me-power @steveberdy
[refactor] test's location
5ff9719
@get-me-power @steveberdy
[delete] Test's api
af26d85 
GetCSharpResultAt(int line, int startColumn, int endColumn, DiagnosticDescriptor descriptor, string bannedMemberName, string message)
GetBasicResultAt(int line, int startColumn, int endColumn, DiagnosticDescriptor descriptor, string bannedMemberName, string message)
@get-me-power @sharwell @steveberdy
Update src/Microsoft.CodeAnalysis.BannedApiAnalyzers/UnitTests/Symbol…
38c924c 
…IsBannedAnalyzerTests.cs

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
@get-me-power @steveberdy
[fix] code style
8fd73a9
@steveberdy
Added operation kinds for operation registration
2d2a8c0
@steveberdy
Improved analyzer and code fixer
061417f
@steveberdy
Analyzer and code fix draft completed
354228f
@Evangelink @steveberdy
Refactor or conditions in DoNotUseInsecureDtdProcessingAnalyzer
5cf0884
@steveberdy
Cleaned code for more performance
82a9cf1
@steveberdy
More code cleanup
6631760
@steveberdy steveberdy closed this Aug 17, 2021
@steveberdy steveberdy deleted the ca1839 branch August 17, 2021 16:59
@steveberdy steveberdy changed the title CA1839: Avoid const arrays CA1839: Avoid const arrays [NO MERGE] Aug 17, 2021
@steveberdy
Copy link
Contributor Author

Branch retargeting destroyed this. See #5383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.