-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement binding and lowering for the with expression (#43249)
A with expression binds to a parameterless, accessible, instance method called Clone on the receiver type. Then, all arguments are bound against record properties with the same name, and the expressions are assigned to the properties' backing fields.
- Loading branch information
Showing
24 changed files
with
1,638 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
177 changes: 177 additions & 0 deletions
177
src/Compilers/CSharp/Portable/Binder/Binder_WithExpression.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| #nullable enable | ||
|
|
||
| using System.Collections.Generic; | ||
| using System.Collections.Immutable; | ||
| using System.Diagnostics; | ||
| using Microsoft.CodeAnalysis.CSharp.Symbols; | ||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | ||
| using Microsoft.CodeAnalysis.PooledObjects; | ||
| using Roslyn.Utilities; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.CSharp | ||
| { | ||
| /// <summary> | ||
| /// This portion of the binder converts a <see cref="WithExpressionSyntax"/> into a <see cref="BoundExpression"/>. | ||
| /// </summary> | ||
| internal partial class Binder | ||
| { | ||
| private BoundExpression BindWithExpression(WithExpressionSyntax syntax, DiagnosticBag diagnostics) | ||
| { | ||
| // PROTOTYPE: this entire method is likely to change | ||
| var receiver = BindRValueWithoutTargetType(syntax.Receiver, diagnostics); | ||
| var receiverType = receiver.Type; | ||
|
|
||
| var lookupResult = LookupResult.GetInstance(); | ||
| HashSet<DiagnosticInfo>? useSiteDiagnostics = null; | ||
| bool hasErrors = false; | ||
|
|
||
| if (receiverType is null || receiverType.IsVoidType()) | ||
| { | ||
| diagnostics.Add(ErrorCode.ERR_InvalidWithReceiverType, syntax.Receiver.Location); | ||
| receiverType = CreateErrorType(); | ||
| } | ||
|
|
||
| MethodSymbol? cloneMethod = null; | ||
| if (!receiverType.IsErrorType()) | ||
| { | ||
| // PROTOTYPE: The receiver type must have a instance method called 'Clone' with no parameters | ||
| LookupMembersInType( | ||
| lookupResult, | ||
| receiverType, | ||
| WellKnownMemberNames.CloneMethodName, | ||
| arity: 0, | ||
| ConsList<TypeSymbol>.Empty, | ||
| LookupOptions.MustBeInstance | LookupOptions.MustBeInvocableIfMember, | ||
| this, | ||
| diagnose: false, | ||
| ref useSiteDiagnostics); | ||
|
|
||
| // PROTOTYPE: Should handle hiding/overriding | ||
| if (lookupResult.IsMultiViable) | ||
| { | ||
| foreach (var symbol in lookupResult.Symbols) | ||
| { | ||
| if (symbol is MethodSymbol { ParameterCount: 0 } m) | ||
| { | ||
| cloneMethod = m; | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| lookupResult.Clear(); | ||
| // PROTOTYPE: discarding use-site diagnostics | ||
| useSiteDiagnostics = null; | ||
|
|
||
| if (cloneMethod is null) | ||
| { | ||
| hasErrors = true; | ||
| diagnostics.Add(ErrorCode.ERR_NoSingleCloneMethod, syntax.Receiver.Location, receiverType); | ||
| } | ||
| else | ||
| { | ||
| // Check return type | ||
| if (!receiverType.IsEqualToOrDerivedFrom( | ||
| cloneMethod.ReturnType, | ||
| TypeCompareKind.ConsiderEverything, | ||
| ref useSiteDiagnostics)) | ||
| { | ||
| hasErrors = true; | ||
| diagnostics.Add( | ||
| ErrorCode.ERR_ContainingTypeMustDeriveFromWithReturnType, | ||
| syntax.Receiver.Location, | ||
| receiverType, | ||
| cloneMethod.ReturnType); | ||
| } | ||
|
|
||
| // PROTOTYPE: discarding use-site diagnostics | ||
| useSiteDiagnostics = null; | ||
| } | ||
| } | ||
|
|
||
| var cloneReturnType = cloneMethod?.ReturnType; | ||
|
|
||
| var args = ArrayBuilder<(Symbol?, BoundExpression)>.GetInstance(); | ||
| // Bind with expression arguments | ||
| foreach (var initializer in syntax.Initializers) | ||
| { | ||
| var propName = initializer.NameEquals?.Name.Identifier.Text; | ||
| Symbol? member = null; | ||
| if (!(propName is null) && !(cloneReturnType is null)) | ||
| { | ||
| var location = initializer.NameEquals!.Name.Location; | ||
| this.LookupMembersInType( | ||
| lookupResult, | ||
| cloneReturnType, | ||
| propName, | ||
| arity: 0, | ||
| basesBeingResolved: null, | ||
| options: LookupOptions.Default, | ||
| originalBinder: this, | ||
| diagnose: false, | ||
| useSiteDiagnostics: ref useSiteDiagnostics); | ||
| // PROTOTYPE: Should handle hiding/overriding and bind like regular accesses | ||
| if (lookupResult.IsSingleViable && | ||
| lookupResult.SingleSymbolOrDefault is var sym) | ||
| { | ||
| switch (sym.Kind) | ||
| { | ||
| case SymbolKind.Property: | ||
| member = sym; | ||
| // PROTOTYPE: this should check for init-only, but that isn't a separate feature yet | ||
| // It also will not work in metadata. | ||
| if (!(sym is SynthesizedRecordPropertySymbol)) | ||
| { | ||
| goto default; | ||
| } | ||
| break; | ||
|
|
||
| default: | ||
| hasErrors = true; | ||
| diagnostics.Add( | ||
| ErrorCode.ERR_WithMemberIsNotRecordProperty, | ||
| location); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (!hasErrors && member is null) | ||
| { | ||
| hasErrors = true; | ||
| Error( | ||
| diagnostics, | ||
| ErrorCode.ERR_NoSuchMemberOrExtension, | ||
| location, | ||
| cloneReturnType, | ||
| propName); | ||
| } | ||
| } | ||
|
|
||
| var expr = BindValue(initializer.Expression, diagnostics, BindValueKind.RValue); | ||
| if (!(member is null)) | ||
| { | ||
| expr = GenerateConversionForAssignment( | ||
| member.GetTypeOrReturnType().Type, | ||
| expr, | ||
| diagnostics); | ||
| } | ||
| lookupResult.Clear(); | ||
| args.Add((member, expr)); | ||
| } | ||
|
|
||
| lookupResult.Free(); | ||
|
|
||
| return new BoundWithExpression( | ||
| syntax, | ||
| receiver, | ||
| cloneMethod, | ||
| args.ToImmutableAndFree(), | ||
| cloneReturnType ?? receiverType, | ||
| hasErrors: hasErrors); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.