Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImplementInterface isn't aware of nullability #30324

Closed
jcouv opened this issue Oct 4, 2018 · 0 comments · Fixed by #36668
Closed

ImplementInterface isn't aware of nullability #30324

jcouv opened this issue Oct 4, 2018 · 0 comments · Fixed by #36668
Assignees
@ryzngard
Labels
Area-IDE Bug New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
Backlog

Comments

@jcouv
Copy link
Member

jcouv commented Oct 4, 2018 •
edited
Loading

Also covers ImplementAbstractClass

image

image

FYI @dpoeschl
@jcouv jcouv added this to the 16.0 milestone Oct 4, 2018
@dpoeschl dpoeschl mentioned this issue Oct 4, 2018
Closed
@jinujoseph jinujoseph added the Bug label Oct 5, 2018
@jinujoseph jinujoseph modified the milestones: 16.0, 16.1 Jan 16, 2019
@jinujoseph jinujoseph modified the milestones: 16.1, Backlog Apr 24, 2019
@jasonmalinowski jasonmalinowski mentioned this issue Jun 20, 2019
Closed
@ryzngard ryzngard mentioned this issue Jun 21, 2019
Merged
ryzngard added a commit that referenced this issue Jun 24, 2019
@ryzngard
Add more nullability awareness in code generation (#36668)
6972d47 
Fixes #30324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryzngard ryzngard

Labels
Area-IDE Bug New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add more nullability awareness in code generation ryzngard/roslyn
3 participants
@ryzngard @jinujoseph @jcouv