Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more nullability awareness in code generation #36668

Merged

Conversation

ryzngard
Copy link
Contributor

Fixes #30324

@ryzngard ryzngard requested a review from a team as a code owner June 21, 2019 21:04
}

[Fact, Trait(Traits.Feature, Traits.Features.CodeActionsImplementInterface)]
public async Task TestWithNullableMethod()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to do events too?

@ryzngard
Copy link
Contributor Author

@jinujoseph @vatsalyaagrawal for approval

@jinujoseph jinujoseph added this to the 16.2.P4 milestone Jun 24, 2019
@ryzngard ryzngard merged commit 6972d47 into dotnet:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImplementInterface isn't aware of nullability
3 participants