WorkspacePullDiagnosticHandler should handle background analysis scope options for both compiler and analyzer diagnostics

[mavasani]

Currently, enabling FSA for either compiler or analyzer diagnostics reports full solution diagnostics for both compiler and analyzers:

roslyn/src/Features/LanguageServer/Protocol/Handler/Diagnostics/WorkspacePullDiagnosticHandler.cs

Lines 176 to 182 in bdbf1cb

	async Task AddDocumentsAndProject(Project project, CancellationToken cancellationToken)
	{
	var fullSolutionAnalysisEnabled = globalOptions.IsFullSolutionAnalysisEnabled(project.Language);
	if (!fullSolutionAnalysisEnabled)
	return;
	var documents = ImmutableArray<TextDocument>.Empty.AddRange(project.Documents).AddRange(project.AdditionalDocuments);

roslyn/src/Features/LanguageServer/Protocol/Features/Options/SolutionCrawlerOptionsStorage.cs

Lines 101 to 113 in bdbf1cb

	/// <summary>
	/// Returns true if the entire solution will be analyzed in the background
	/// to compute up-to-date diagnostics for the error list.
	/// Note that the background analysis scope for compiler diagnostics and
	/// analyzers can be different. If you want to fetch individual values for
	/// whether or not full solution analysis is enabled for compiler diagnostics
	/// and analyzers, use the other overload
	/// <see cref="IsFullSolutionAnalysisEnabled(IGlobalOptionService, string, out bool, out bool)"/>.
	/// </summary>
	public static bool IsFullSolutionAnalysisEnabled(
	this IGlobalOptionService globalOptions,
	string language)
	=> globalOptions.IsFullSolutionAnalysisEnabled(language, out _, out _);

We need to trigger FSA for selected analyzers (compiler and/or other analyzers) based on both options. For optimal performance, this should be done as a pre-filtering of analyzers to execute rather than post-filtering of diagnostics reported from both compiler and analyzers.

[mavasani]

FYI @dibarbet - I'll work on a fix.