Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static variables used in determineBrowserType #5919

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix static variables used in determineBrowserType #5919

merged 1 commit into from
Jul 13, 2023

Conversation

WardenGnaw
Copy link
Contributor

This PR fixes the 'this' to be 'BlazorDebugConfigurationProvider' for the new static variables from #5911

5911 introduces a bug as it will throw an exception as undefined does not have a replace method and it will always be returning undefined

@WardenGnaw
Fix static variables used in determineBrowserType
c51bbf7 
This PR fixes the 'this' to be 'BlazorDebugConfigurationProvider' for
the new static variables from #5911
@WardenGnaw WardenGnaw requested a review from a team as a code owner July 13, 2023 22:48
@WardenGnaw WardenGnaw merged commit 58a7151 into main Jul 13, 2023
arunchndr added a commit that referenced this pull request Jul 18, 2023
@arunchndr @dibarbet
@JoeRobich @leslierichardson95 @mavasani @WardenGnaw @davidwengier @ryzngard @mikadumont @dependabot @isadorasophia
Snap main for C# prerelease 07/17 (#5927)
4491904 
* Increase release CI timeout

* Add CI for release branch

* Add eslint and fix warnings

* Implement report issue command for prerelease extension

* Update O# Roslyn and prepare for release

* Switch to non-deprecated action for asset upload

* Upload all VSIX in one step

* Update .github/workflows/release-ci.yml

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>

* Update release-ci.yml

* review feedback

* use vscode-uri

* Add write permissions to job

* Fix options schema

* Explicitly throw if runtimeId is missing

* Use real looking runtimeId in fake

* Use issue reporter command

* Add server path as an option to allow Razor to re-use the runtime resolver

* Fix brace

* More lint

* Update README.md to notify user about .NET Runtime Tool

* Enable full solution background analysis

- Adds 2 new background analysis scope options: one for compiler diagnostics and one for analyzer diagnostics
- Both the options allow the same set of values as in VS: Open documents, Entire solution, Current document and None (disabled). Currently, `Current document` option is not yet supported in LSP as we do not have a way to know which is the current active document in LSP server.
- Builds on top of dotnet/roslyn#68799
- Needs couple more Roslyn side changes as a follow-up: dotnet/roslyn#68797 and dotnet/roslyn#68798

* Remove the un-supported `Current Document` option

* File renames

* Remove TSLint and configure eslint

* Enable remaining rules from tslint and remove

* Run prettier automatic fixer

* address a couple remaining eslint errors

* Remove incorrectly cased folders

* Remove duplicate license header

* Fix options schema after package.json changes

* Fix chai test assertion library usages

* Avoid using 'solution crawler' terminology in the VSCode option name

* Address feedback and fix test

* Revert unintentional changes from merge

* Some more reverts

* Address feedback and also fix linting issues

* Revert "Merged PR 475885: Add support for F5 for csproj and sln" (#5875)

This reverts commit 173be18.

* Update README.md to make runtime extension note numbered

* Bump Razor to 7.0.0-preview.23328.2

* Allow updatePackageDependencies to work with Razor (well, with prerelease packages)

* Add task for updating Razor deps

* Move to newer version of Roslyn LSP server

* Remove unsupported feature

* Update regexes

* small edits to readme

* deleted extra space in readme

* Try a less recent Razor version

* Update roslyn

* Remove pwa- prefix from BlazorDebug (#5908)

This PR removes pwa- from msedge and chrome as this was an older debug
type that is now depricated.

See microsoft/vscode-js-debug#1305

* Add determineBrowserType to CSharpExtensionExports (#5911)

This PR exports the
BlazorDebugConfigurationProvider.determineBrowserType method that it
could be used in vscode-dotnettools to help determine the browser the
user wants to use.

* Bump semver from 5.6.0 to 5.7.2

Bumps [semver](https://github.com/npm/node-semver) from 5.6.0 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.6.0...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update debugger packages to 2.0.2 (#5914)

Co-authored-by: Isadora Rodopoulos <isgarcia@microsoft.com>

* Fix static variables used in determineBrowserType (#5919)

This PR fixes the 'this' to be 'BlazorDebugConfigurationProvider' for
the new static variables from #5911

* Add call to setupTelemetryEnvironmentAsync (#5922)

* Add call to setupTelemetryEnvironmentAsync

* Make optional

* Update Roslyn server (#5925)

* Update Roslyn server

* Update package.json

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: David Barbet <dabarbet@microsoft.com>
Co-authored-by: David Barbet <dibarbet@gmail.com>
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
Co-authored-by: leslierichardson95 <LERICH@microsoft.com>
Co-authored-by: Manish Vasani <mavasani@microsoft.com>
Co-authored-by: Andrew Wang <waan@microsoft.com>
Co-authored-by: David Wengier <git@wengier.com>
Co-authored-by: Andrew Hall (METAL) <andrha@microsoft.com>
Co-authored-by: Mika Dumont <midumont@microsoft.com>
Co-authored-by: Mika Dumont <46729679+mikadumont@users.noreply.github.com>
Co-authored-by: David Wengier <david.wengier@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isadora <isaecia@gmail.com>
Co-authored-by: Isadora Rodopoulos <isgarcia@microsoft.com>
333fred added a commit that referenced this pull request Jul 18, 2023
@333fred
Merge remote-tracking branch 'upstream/main' into add-experimental-api
9aa618c 
* upstream/main: (26 commits)
  Update Roslyn server (#5925)
  Add call to setupTelemetryEnvironmentAsync (#5922)
  Fix static variables used in determineBrowserType (#5919)
  Update debugger packages to 2.0.2 (#5914)
  Bump semver from 5.6.0 to 5.7.2
  Add determineBrowserType to CSharpExtensionExports (#5911)
  Remove pwa- prefix from BlazorDebug (#5908)
  Update roslyn
  Try a less recent Razor version
  deleted extra space in readme
  small edits to readme
  Update regexes
  Remove unsupported feature
  Add task for updating Razor deps
  Allow updatePackageDependencies to work with Razor (well, with prerelease packages)
  Bump Razor to 7.0.0-preview.23328.2
  Update README.md to make runtime extension note numbered
  Update README.md to notify user about .NET Runtime Tool
  Add write permissions to job
  Update release-ci.yml
  ...
@JoeRobich JoeRobich deleted the dev/waan/fixdetermineBrowserType branch October 8, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosGuerraVz CarlosGuerraVz CarlosGuerraVz approved these changes

@lonitra lonitra lonitra approved these changes

@isadorasophia isadorasophia isadorasophia approved these changes

@gregg-miskelly gregg-miskelly Awaiting requested review from gregg-miskelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WardenGnaw @isadorasophia @lonitra @CarlosGuerraVz