Roslyn side changes for the new toggle button added to the Error list… #11439
Conversation
… to turn on/off full solution analysis We are moving the "Enable full solution analysis" option from Tools Option to the error list for improved discoverability, while also making it language agnostic. This change ensures that we set the Roslyn full solution analysis options when this button is toggled in the error list. Additionally, when we identify that the error list toggle button is available (Dev14 U3 or later), we will hide the tools option checkbox for "Enable full solution analysis" and show a note about it being moved to the error list. Note that we still continue with language specific defaults (C# off, VB on), but once the user has hit the error list toggle, the option setting is consistent across all languages. Addresses workitem dotnet#11392
|
Tagging @heejaechang @srivatsn @dotnet/roslyn-analysis for review. |
| @@ -54,6 +54,7 @@ | |||
| Content="{x:Static local:AdvancedOptionPageStrings.Option_ClosedFileDiagnostics}" /> | |||
| <CheckBox x:Name="RenameTrackingPreview" | |||
| Content="{x:Static local:AdvancedOptionPageStrings.Option_RenameTrackingPreview}" /> | |||
| <Label x:Name="FullSolutionAnalysisMovedToErrorListLabel" Content="Note: Option "Enable full solution analysis" has been moved to the Error List." Visibility="Collapsed"/> | |||
There was a problem hiding this comment.
Should we give a more descriptive message here about the positioning or kind of the button (toggle button)?
There was a problem hiding this comment.
should this be localized?
There was a problem hiding this comment.
Yes, most certainly. Will do.
|
except localization and interface stuff, 👍 |
|
@heejaechang fixed localization. will remove interfaces once we have NuGet package for new shell binary |
|
@jasonmalinowski @Pilchie @DustinCampbell to review changes to options. Also tagging @paulvanbrenk since this will impact TypeScript. |
|
@srivatsn where does this impact TypeScript? We don't have an option.... or do we now get one 'for free' |
|
If someone is working on a TypeScript project, will they see this button in the Error list (even though it does not do anything since TypeScript always does FSD)? |
|
@paulvanbrenk If you don't have an option then there's no impact. @natidea Yes they'll still see the button. It's not just typescript. Even if I have nothing open, turning on\off the option just means try harder and some provider will and some won't. |
mavasani
force-pushed
the
Issue11392
branch
2 times, most recently
from
f5ae74b
to
8d11ab8
Compare
|
@srivatsn @heejaechang - I have updated the PR as per today's discussion. Only pending part is moving to new shell nupkg, after which I'll merge this change. |
| if (fullAnalysisState) | ||
| { | ||
| var langauges = e.NewSolution.Projects.Select(p => p.Language).Distinct(); | ||
| foreach (var language in langauges) |
|
retest vsi please |
…od marked with [MethodImpl(MethodImplOptions.NoInlining)]
|
retest vsi please |
|
All tests passed and verified manually too. |
… to turn on/off full solution analysis
We are moving the "Enable full solution analysis" option from Tools Option to the error list for improved discoverability, while also making it language agnostic. This change ensures that we set the Roslyn full solution analysis options when this button is toggled in the error list. Additionally, when we identify that the error list toggle button is available (Dev14 U3 or later), we will hide the tools option checkbox for "Enable full solution analysis" and show a note about it being moved to the error list. Note that we still continue with language specific defaults (C# off, VB on), but once the user has hit the error list toggle, the option setting is consistent across all languages.
Addresses workitem #11392