Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roslyn side changes for the new toggle button added to the Error list… #11439

Merged
merged 6 commits into from
May 21, 2016

Commits on May 19, 2016

  1. Roslyn side changes for the new toggle button added to the Error list…

    … to turn on/off full solution analysis
    
    We are moving the "Enable full solution analysis" option from Tools Option to the error list for improved discoverability, while also making it language agnostic. This change ensures that we set the Roslyn full solution analysis options when this button is toggled in the error list. Additionally, when we identify that the error list toggle button is available (Dev14 U3 or later), we will hide the tools option checkbox for "Enable full solution analysis" and show a note about it being moved to the error list. Note that we still continue with language specific defaults (C# off, VB on), but once the user has hit the error list toggle, the option setting is consistent across all languages.
    
    Addresses workitem dotnet#11392
    mavasani committed May 19, 2016
    Configuration menu
    Copy the full SHA
    deff632 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2016

  1. Configuration menu
    Copy the full SHA
    7a6f4b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca0edce View commit details
    Browse the repository at this point in the history

Commits on May 21, 2016

  1. Address PR feedback

    mavasani committed May 21, 2016
    Configuration menu
    Copy the full SHA
    05594cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18b4d37 View commit details
    Browse the repository at this point in the history
  3. Move the code accessing the new IErrorList2 type into a separate meth…

    …od marked with [MethodImpl(MethodImplOptions.NoInlining)]
    mavasani committed May 21, 2016
    Configuration menu
    Copy the full SHA
    990a60b View commit details
    Browse the repository at this point in the history