Merge from master to features/readonly-ref #18308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility fixes for Naming Styles
The build depends on a global tool corflags to complete. Unblocking build for now.
Fixing the test-result table in README.md
remove space from case.
Fix unintentional removal of "InsertionText" property from implements…
Suggest names after types
…r-20170319-070004 Merge dev15.1.x to master
…r-20170320-070003 Merge dev15.1.x to master
…ile-checkouts Don't require an invisible editor to be opened when we're locating nodes
…ssTargetingP2P Pick the right project for P2P refs in lightweight solution load and cross-targeting
Add C# and VB QuickInfo integration tests
…ions Allow a user to generate operators when generating .Equals
Update our language feature status.
Be resilient to being unable to resolve the location of a symbol in a different compilation.
…r-20170321-070004 Merge dev15.1.x to master
Unify the object-creation expressions we produce.
Add Generate-Equals tests.
* Responded to PR comments on dotnet#17894 * Added more tests, and supporting 1.0, 2.0, 3.0, etc... versions * Clean up
Changes the content builder to have better diagnostics about missing references. In particular it now shows all of the assemblies which referenced the missing value.
Update common references to v4.6 in TestWorkspace
…nteractiveFormsAndWpf, CSharpReplClassification, CSharpInteractiveCommands, REPL Intellisence, CSharpSendToInteractive (dotnet#18137)
Don't offer to add a using to resolve 'var'.
Part of building up our content file for a test description includes calculating checksums for several thousand assemblies. This takes up a significant amount of time if done without optimization (~1 minute). To optimize this process RunTests caches checksums on a couple of levels. One cache is based on file path. The tool assumes the file system is static for the duration of the run and hence caches checksums based on file paths. This cache was added back when the build outputed the majority of the build to a single directory. There are a lot of common assemblies between our tests hence this was a very effective cache. Since we've moved to a more granular output structure this cache is becoming extremely ineffective. This change replaces it with an MVID based cache. Calculating the checksum of an assembly is relatively expensive but reading it's MVID is cheap and it's an effective content key for PEs. Local measurements show this saved us 55% on calculating the content for the entirety of our test run set (about 20 seconds).
Parenthesize assignment expression when creating collection initializer element.
Move base-type-list syntax checks out of the parser.
Fix typo ("warnaserror" vs "warningaserror")...
The spaces were missing after the ##, which led to github rendering the line as text rather than as a heading.
Reorder asserts in BuildWithCommandLine so we can see log output duri…
Update headings to be github markdown compatible
The motivation for this change is to simplify our build and develop steps. Previously our compiler builds included files generated into the Obj folder during previous phases of the build. This meant that in order to open Roslyn.sln successfully the code needed to be built first. Not ideal. The generated code involved is rarely changed. But in order to build the generators themselves must be built and run as a part of every build. This is doable but adds unncessary overhead to development and complicates our build files a bit. This approach checks in the generated files which should have the following benefits: - Roslyn.sln can be open after a restore - Build process is simplified and marginally faster for many operations - Generated code now participates in GitLink
Checking in on behalf of @shrayasr. Thanks!
Avoiding turning RValue expressions into effectively LValues as a sideeffect of lowering reductions
Add feature .md for `async` task types
* Fixing Flaky Interactive Tests dotnet#18283 * make verification condition weaker but still enough. adding more diagnostis
|
@OmarTawfik - FYI |
|
@dotnet-bot test windows_debug_vs-integration_prtest please |
|
@dotnet-bot test windows_release_vs-integration_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.