Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release/dev16.6 to master #43465

Merged
2 commits merged into from
Apr 18, 2020
Merged

Merge release/dev16.6 to master #43465

2 commits merged into from
Apr 18, 2020

Commits on Apr 16, 2020

  1. Remove public API on DocumentOptionSet 

    #42931 added this API as we thought converting the base `OptionSet` type's abstract method to non-abstract and removing the override on `DocumentOptionSet` would be a binary breaking change for callers. However, based on the public API review meeting, it was identified that it would indeed not be a breaking change as the compiler would have emitted a callvirt to `OptionSet.GetOption`.
    @mavasani
    mavasani committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    b9e9a3e View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Merge pull request #43428 from mavasani/ApiBreakFix 

    Remove public API on DocumentOptionSet
    @mavasani
    mavasani authored Apr 17, 2020
    Configuration menu
    Copy the full SHA
    6c5512f View commit details
    Browse the repository at this point in the history