Fixed VS crash during implicit conversion of null object in nullable walker #45974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please use more descriptive titles for PRs in the future? |
kevinsun-dev
changed the title
Apologies, forgot to change the title from when it was a draft. |
cston
reviewed
Jul 15, 2020
| @@ -5537,7 +5537,7 @@ private Conversion GenerateConversionForConditionalOperator(BoundExpression sour | |||
| private static Conversion GenerateConversion(Conversions conversions, BoundExpression sourceExpression, TypeSymbol sourceType, TypeSymbol destinationType, bool fromExplicitCast, bool extensionMethodThisArgument) | |||
| { | |||
| HashSet<DiagnosticInfo> useSiteDiagnostics = null; | |||
| bool useExpression = UseExpressionForConversion(sourceExpression); | |||
| bool useExpression = (sourceType is null) ? true : UseExpressionForConversion(sourceExpression); | |||
There was a problem hiding this comment.
Consider writing as sourceType is null || UseExpressionForConversion(sourceExpression).
cston
reviewed
Jul 15, 2020
| }; | ||
| } | ||
| }"; | ||
| var comp = CreateCompilation(new[] { source }, parseOptions: TestOptions.Regular8, options: WithNonNullTypesTrue(TestOptions.ReleaseModule)); |
There was a problem hiding this comment.
Can be simplified to var comp = CreateCompilation(source);
cston
reviewed
Jul 15, 2020
| @@ -4780,6 +4780,37 @@ void F(System.Action<System.Object?, System.Action<System.Object!, System.Object | |||
| }); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [WorkItem(45862, "https://github.com/dotnet/roslyn/issues/45862")] | |||
| public void Issue_45862() | |||
There was a problem hiding this comment.
Consider moving to NullableReferenceTypesTests.cs.
There was a problem hiding this comment.
Consider giving the test a descriptive name, perhaps "SwitchExpressionNoType".
In reply to: 455193504 [](ancestors = 455193504)
cston
approved these changes
Jul 15, 2020
ghost
modified the milestones:
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 17, 2020
* upstream/master: (86 commits) Better client / server logging (dotnet#46079) Fix OptProf config Update src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs Do not execute RemoveUnnecessaryInlineSuppressions on generated code Update dependencies from https://github.com/dotnet/arcade build 20200715.6 (dotnet#46086) Use ISpanMapper before sending cross file results to LSP Add additional module initializers tests from review (dotnet#46020) Fix type in OptProf configuration bump to 500 Fixed VS crash during implicit conversion of null object in nullable walker (dotnet#45974) Rename variable Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagnosticAnalyzer Check modifiers on record positional members (dotnet#45898) Fix typos and link in Source Generators cookbook (dotnet#44372) Remove reference to non-existing VisualStudioInteractiveComponents.vsix from deployment VSIX. (dotnet#45979) Address feedback + fix tests Update dependencies from https://github.com/dotnet/roslyn build 20200711.1 (dotnet#45932) Make MetadataTypeName non-copyable Fix usage of GetService extension Consolidate service provider extensions ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 23, 2020
…to function-pointer-type-lookup * upstream/features/function-pointers: (86 commits) Better client / server logging (dotnet#46079) Fix OptProf config Update src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs Do not execute RemoveUnnecessaryInlineSuppressions on generated code Update dependencies from https://github.com/dotnet/arcade build 20200715.6 (dotnet#46086) Use ISpanMapper before sending cross file results to LSP Add additional module initializers tests from review (dotnet#46020) Fix type in OptProf configuration bump to 500 Fixed VS crash during implicit conversion of null object in nullable walker (dotnet#45974) Rename variable Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagnosticAnalyzer Check modifiers on record positional members (dotnet#45898) Fix typos and link in Source Generators cookbook (dotnet#44372) Remove reference to non-existing VisualStudioInteractiveComponents.vsix from deployment VSIX. (dotnet#45979) Address feedback + fix tests Update dependencies from https://github.com/dotnet/roslyn build 20200711.1 (dotnet#45932) Make MetadataTypeName non-copyable Fix usage of GetService extension Consolidate service provider extensions ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed VS crash during implicit conversion due to null object. Documented in issue #45862.
Changes: