Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional module initializers tests #46020

Merged

Conversation

RikkiGibson
Copy link
Contributor

Related to #40500

Adds tests suggested in review of #45969.

@RikkiGibson RikkiGibson added Area-Compilers Test Test failures in roslyn-CI labels Jul 15, 2020
@RikkiGibson RikkiGibson requested a review from a team as a code owner July 15, 2020 22:59
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@RikkiGibson RikkiGibson merged commit ab38a9d into dotnet:features/module-initializers Jul 17, 2020
@RikkiGibson RikkiGibson deleted the mi-more-testing branch July 17, 2020 00:10
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 17, 2020
* upstream/master: (86 commits)
  Better client / server logging (dotnet#46079)
  Fix OptProf config
  Update src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs
  Do not execute RemoveUnnecessaryInlineSuppressions on generated code
  Update dependencies from https://github.com/dotnet/arcade build 20200715.6 (dotnet#46086)
  Use ISpanMapper before sending cross file results to LSP
  Add additional module initializers tests from review (dotnet#46020)
  Fix type in OptProf configuration
  bump to 500
  Fixed VS crash during implicit conversion of null object in nullable walker (dotnet#45974)
  Rename variable
  Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagnosticAnalyzer
  Check modifiers on record positional members (dotnet#45898)
  Fix typos and link in Source Generators cookbook (dotnet#44372)
  Remove reference to non-existing VisualStudioInteractiveComponents.vsix from deployment VSIX. (dotnet#45979)
  Address feedback + fix tests
  Update dependencies from https://github.com/dotnet/roslyn build 20200711.1 (dotnet#45932)
  Make MetadataTypeName non-copyable
  Fix usage of GetService extension
  Consolidate service provider extensions
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 23, 2020
…to function-pointer-type-lookup

* upstream/features/function-pointers: (86 commits)
  Better client / server logging (dotnet#46079)
  Fix OptProf config
  Update src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs
  Do not execute RemoveUnnecessaryInlineSuppressions on generated code
  Update dependencies from https://github.com/dotnet/arcade build 20200715.6 (dotnet#46086)
  Use ISpanMapper before sending cross file results to LSP
  Add additional module initializers tests from review (dotnet#46020)
  Fix type in OptProf configuration
  bump to 500
  Fixed VS crash during implicit conversion of null object in nullable walker (dotnet#45974)
  Rename variable
  Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagnosticAnalyzer
  Check modifiers on record positional members (dotnet#45898)
  Fix typos and link in Source Generators cookbook (dotnet#44372)
  Remove reference to non-existing VisualStudioInteractiveComponents.vsix from deployment VSIX. (dotnet#45979)
  Address feedback + fix tests
  Update dependencies from https://github.com/dotnet/roslyn build 20200711.1 (dotnet#45932)
  Make MetadataTypeName non-copyable
  Fix usage of GetService extension
  Consolidate service provider extensions
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test Test failures in roslyn-CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants