Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer more specific path map key #49670

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Prefer more specific path map key #49670

merged 2 commits into from
Dec 10, 2020

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 30, 2020

Fixes #46061

@tmat tmat requested a review from a team as a code owner November 30, 2020 20:11
@jcouv jcouv self-assigned this Dec 2, 2020
@jcouv
Copy link
Member

jcouv commented Dec 2, 2020

Do we need to document this as a breaking change in some way?

jcouv
jcouv approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@tmat
Copy link
Member Author

tmat commented Dec 3, 2020

Do we need to document this as a breaking change in some way?

Maybe. I wouldn't think this would cause a serious issue in practice, but if we want to track it in some breaking changes list I can add a note there. LMK.

@RikkiGibson RikkiGibson self-assigned this Dec 9, 2020
@tmat tmat merged commit d3bc63f into dotnet:master Dec 10, 2020
@ghost ghost added this to the Next milestone Dec 10, 2020
@tmat tmat deleted the PathMap branch December 10, 2020 18:15
333fred added a commit to 333fred/roslyn that referenced this pull request Dec 15, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merge-master
b378406 
* upstream/master: (241 commits)
  Allow pattern matching `null` against pointer types when the pointer types contain nested type parameters (dotnet#49915)
  Remove document extension method and convert usages to use the text buffer extension method.
  VB: Strengthen implementation of `PropertySymbol.IsWritable` against NullReferenceException (dotnet#49962)
  Add switch to skip nullable analysis (dotnet#49876)
  Update dependencies from https://github.com/dotnet/roslyn build 20201211.16 (dotnet#49958)
  Treat record positional parameters as properties (dotnet#48329)
  [master] Update dependencies from dotnet/roslyn (dotnet#49395)
  VB: Ensure array access indexes undergo conversion to integer even when there is a mismatch with array rank. (dotnet#49907)
  Disable OOP when running as cloud environment client VS instance
  Rename workspace context method (and unify impls) to better represent the condition being checked
  Report non-Const locals used in an expression that must have a constant value. (dotnet#49912)
  Add support for more ServiceAudience values (dotnet#49914)
  Handle ref-containing structs returned by value from function-pointers (dotnet#49883)
  Fix error on out param of extern local function (dotnet#49860)
  Fix constructor exit warnings for generic NotNull (dotnet#49841)
  Loc updates
  Prefer more specific path map key (dotnet#49670)
  Rename `_availablelocalFunctionOrdinal` to `_availableLocalFunctionOrdinal` (dotnet#49901)
  Fix namespace so that external access wrapper type can be accessed from UT.
  XamlProjectService fixes (dotnet#49711)
  ...
@dibarbet dibarbet modified the milestones: Next, 16.9.P3 Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@RikkiGibson RikkiGibson

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
16.9.P3
Development

Successfully merging this pull request may close these issues.

PathMap should prefer more specific prefix mapping
6 participants
@tmat @jcouv @jaredpar @RikkiGibson @dibarbet @Dotnet-GitSync-Bot