Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB: Ensure array access indexes undergo conversion to integer even when there is a mismatch with array rank. #49907

Merged
merged 1 commit into from
Dec 11, 2020
Merged

VB: Ensure array access indexes undergo conversion to integer even when there is a mismatch with array rank. #49907

merged 1 commit into from
Dec 11, 2020

Conversation

AlekseyTs
Copy link
Contributor

Fixes #49904.

@AlekseyTs AlekseyTs added Language-VB Area-Compilers Tenet-Reliability Customer telemetry indicates that the product is failing in a crash/hang/dataloss manner. labels Dec 10, 2020
@AlekseyTs AlekseyTs requested a review from a team December 10, 2020 18:58
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review, need a second sign-off

@333fred
Copy link
Member

333fred commented Dec 11, 2020

Looking

333fred
333fred approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@AlekseyTs AlekseyTs merged commit 6a6d96f into dotnet:master Dec 11, 2020
@ghost ghost added this to the Next milestone Dec 11, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Dec 15, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merge-master
b378406 
* upstream/master: (241 commits)
  Allow pattern matching `null` against pointer types when the pointer types contain nested type parameters (dotnet#49915)
  Remove document extension method and convert usages to use the text buffer extension method.
  VB: Strengthen implementation of `PropertySymbol.IsWritable` against NullReferenceException (dotnet#49962)
  Add switch to skip nullable analysis (dotnet#49876)
  Update dependencies from https://github.com/dotnet/roslyn build 20201211.16 (dotnet#49958)
  Treat record positional parameters as properties (dotnet#48329)
  [master] Update dependencies from dotnet/roslyn (dotnet#49395)
  VB: Ensure array access indexes undergo conversion to integer even when there is a mismatch with array rank. (dotnet#49907)
  Disable OOP when running as cloud environment client VS instance
  Rename workspace context method (and unify impls) to better represent the condition being checked
  Report non-Const locals used in an expression that must have a constant value. (dotnet#49912)
  Add support for more ServiceAudience values (dotnet#49914)
  Handle ref-containing structs returned by value from function-pointers (dotnet#49883)
  Fix error on out param of extern local function (dotnet#49860)
  Fix constructor exit warnings for generic NotNull (dotnet#49841)
  Loc updates
  Prefer more specific path map key (dotnet#49670)
  Rename `_availablelocalFunctionOrdinal` to `_availableLocalFunctionOrdinal` (dotnet#49901)
  Fix namespace so that external access wrapper type can be accessed from UT.
  XamlProjectService fixes (dotnet#49711)
  ...
@dibarbet dibarbet modified the milestones: Next, 16.9.P3 Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Language-VB Tenet-Reliability Customer telemetry indicates that the product is failing in a crash/hang/dataloss manner.
Projects
None yet
Milestone
16.9.P3
Development

Successfully merging this pull request may close these issues.

Unreachable code exception is thrown for incomplete With statement
4 participants
@AlekseyTs @333fred @cston @dibarbet