Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'main' into 'features/GlobalUsingDirective' #52098

Merged
617 commits merged into from
Mar 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
617 commits
Select commit Hold shift + click to select a range
1f40bd9
Merge branch 'dotnet/main' into features/argument-completion
jasonmalinowski Mar 11, 2021
1d21812
Use ImmutableSegmentedDictionary in the analyzer driver
sharwell Mar 11, 2021
643f8a2
Add unnamed symbols
CyrusNajmabadi Mar 11, 2021
789a1d6
Simplify
CyrusNajmabadi Mar 11, 2021
f5236e7
Merge pull request #51795 from dotnet/merges/release/dev16.9-vs-deps-…
Mar 11, 2021
1a9f0d6
simplify
CyrusNajmabadi Mar 11, 2021
3c7c673
Simplify code.
CyrusNajmabadi Mar 11, 2021
08b3c34
NRT and switch expression
CyrusNajmabadi Mar 11, 2021
15c9e86
Merge pull request #51804 from jasonmalinowski/update-argument-comple…
Mar 11, 2021
1ba6c4c
Intermediate
CyrusNajmabadi Mar 11, 2021
72a65e0
Simplify
CyrusNajmabadi Mar 11, 2021
93cba16
Fix
CyrusNajmabadi Mar 11, 2021
6fb1338
Fix
CyrusNajmabadi Mar 11, 2021
6e98175
Fix
CyrusNajmabadi Mar 11, 2021
27913e0
Pass cancellation token to Dequeue method, and rewrite comment (#51794)
davidwengier Mar 11, 2021
2d3fd7d
Simplify more
CyrusNajmabadi Mar 11, 2021
1e722bd
Fix test
CyrusNajmabadi Mar 11, 2021
2f14568
Merge remote-tracking branch 'upstream/release/dev16.10' into merges/…
dibarbet Mar 11, 2021
625a02c
Cancel outstanding work on tagger disconnect
sharwell Mar 11, 2021
7550ac6
Use RTM version of framework ref assemblies
jaredpar Mar 11, 2021
8d00209
Merge branch 'simplifyCompletion' into intellisenseExplicitCast
CyrusNajmabadi Mar 12, 2021
8dc4c81
Merge code in
CyrusNajmabadi Mar 12, 2021
aac0ad7
Merge remote-tracking branch 'sharwell/cancel-work' into intellisense…
CyrusNajmabadi Mar 12, 2021
1ef9442
Merge remote-tracking branch 'upstream/main' into intellisenseExplici…
CyrusNajmabadi Mar 12, 2021
960bebb
nrt'
CyrusNajmabadi Mar 12, 2021
db8c84e
revert'
CyrusNajmabadi Mar 12, 2021
38be2dc
Don't use docker for sourcebuild leg (#51815)
333fred Mar 12, 2021
8fb36c3
Update generated action table column names
JoeRobich Mar 12, 2021
062355a
Add Rebuild.UnitTests (#51778)
RikkiGibson Mar 12, 2021
edccfb4
Merge pull request #51816 from sharwell/cancel-work
sharwell Mar 12, 2021
24de972
Merge pull request #51806 from dotnet/merges/release/dev16.10-to-main
allisonchou Mar 12, 2021
7e99a9a
Merge pull request #51805 from sharwell/faster-driver
sharwell Mar 12, 2021
a8fbfe4
Remove unused common diagnostic analyzers
sharwell Mar 12, 2021
d23cc29
Add component debugger support to target files (#51449)
chsienki Mar 12, 2021
8da536d
Merge pull request #51811 from CyrusNajmabadi/simplifyCompletion
Mar 12, 2021
ecdb876
Merge pull request #51819 from jaredpar/name
Mar 12, 2021
5de1dd0
Port logic
CyrusNajmabadi Mar 12, 2021
ed4b6da
Avoid delegate allocations in AbstractLogAggregator.GetCounter
sharwell Mar 12, 2021
bcd1dab
Compiling
CyrusNajmabadi Mar 12, 2021
f1c7aa3
Merge remote-tracking branch 'upstream/main' into intellisenseExplici…
CyrusNajmabadi Mar 12, 2021
a8f4a14
Compile
CyrusNajmabadi Mar 12, 2021
78eb064
NOt in nameof
CyrusNajmabadi Mar 12, 2021
b8a257d
ONly when isntance members allowed
CyrusNajmabadi Mar 12, 2021
9b1476e
Add conversion
CyrusNajmabadi Mar 12, 2021
ea57c06
not after a number
CyrusNajmabadi Mar 12, 2021
a4a1074
look through all members
CyrusNajmabadi Mar 12, 2021
984fb64
Avoid delegate allocations for logger calls
sharwell Mar 12, 2021
560b61f
some amount of lifting
CyrusNajmabadi Mar 12, 2021
11d3776
Simplify fast path in AssemblyIdentityComparer.Compare
sharwell Mar 12, 2021
be2b75f
MOre conversions work
CyrusNajmabadi Mar 12, 2021
c8e4862
Operator change
CyrusNajmabadi Mar 12, 2021
c45d786
Fix test
CyrusNajmabadi Mar 12, 2021
39a98a3
docs
CyrusNajmabadi Mar 12, 2021
64b52d3
double id
CyrusNajmabadi Mar 12, 2021
7925ff7
Test pass
CyrusNajmabadi Mar 13, 2021
3bb653c
Simplify
CyrusNajmabadi Mar 13, 2021
cce82d4
No nullable for summary
CyrusNajmabadi Mar 13, 2021
9cbd489
update tests
CyrusNajmabadi Mar 13, 2021
995b585
update tests
CyrusNajmabadi Mar 13, 2021
ea3d109
index range
CyrusNajmabadi Mar 13, 2021
16e0e2b
doc comments
CyrusNajmabadi Mar 13, 2021
76b15ba
Fix tests'
CyrusNajmabadi Mar 13, 2021
bb51a1d
Fix tests'
CyrusNajmabadi Mar 13, 2021
0b5b66f
Fix tests'
CyrusNajmabadi Mar 13, 2021
11f87c5
Fix'
CyrusNajmabadi Mar 13, 2021
70b3fba
UPdate test
CyrusNajmabadi Mar 13, 2021
f962097
Fix questions
CyrusNajmabadi Mar 13, 2021
1504aea
fix test
CyrusNajmabadi Mar 13, 2021
93b76c2
rename
CyrusNajmabadi Mar 13, 2021
ecc3288
always include the op
CyrusNajmabadi Mar 13, 2021
d2c587a
Fixes
CyrusNajmabadi Mar 13, 2021
28d97d0
fix tests
CyrusNajmabadi Mar 13, 2021
dd85f1e
Fix ordering
CyrusNajmabadi Mar 13, 2021
d6c1db9
Remove'
CyrusNajmabadi Mar 13, 2021
00d48a3
Get building
CyrusNajmabadi Mar 13, 2021
a0c09bd
Fix dotdot case
CyrusNajmabadi Mar 13, 2021
f2a81d4
Fix tests
CyrusNajmabadi Mar 13, 2021
0719ea7
don't make nullable reference types
CyrusNajmabadi Mar 13, 2021
65e4868
Fix tests
CyrusNajmabadi Mar 13, 2021
1ad4499
add test'
CyrusNajmabadi Mar 13, 2021
fae2b4e
Add test
CyrusNajmabadi Mar 13, 2021
b1f8758
Add tests
CyrusNajmabadi Mar 13, 2021
673166a
add test'
CyrusNajmabadi Mar 13, 2021
18f6ad1
NO need to lift operators'
CyrusNajmabadi Mar 13, 2021
fb41fec
simplify
CyrusNajmabadi Mar 13, 2021
027c0c5
Use x and y
CyrusNajmabadi Mar 13, 2021
b425171
Handle operator overloads
CyrusNajmabadi Mar 13, 2021
1abb87e
Simplify
CyrusNajmabadi Mar 13, 2021
4988260
Simplify operators
CyrusNajmabadi Mar 13, 2021
c1546b1
restore
CyrusNajmabadi Mar 13, 2021
16650a7
revert
CyrusNajmabadi Mar 13, 2021
2068af2
comments
CyrusNajmabadi Mar 13, 2021
5fe0a95
Cleanup
CyrusNajmabadi Mar 13, 2021
668e3ad
simplify
CyrusNajmabadi Mar 13, 2021
88548d3
Fixes
CyrusNajmabadi Mar 13, 2021
9bbc99e
Fix
CyrusNajmabadi Mar 13, 2021
1f2df0a
test fixes'
CyrusNajmabadi Mar 13, 2021
f09f182
test fixes'
CyrusNajmabadi Mar 13, 2021
0c933d5
simplify
CyrusNajmabadi Mar 13, 2021
5e7e061
simplify
CyrusNajmabadi Mar 13, 2021
1dc3af7
simplify
CyrusNajmabadi Mar 13, 2021
44a08a6
Filter unnamed symbols as well
CyrusNajmabadi Mar 13, 2021
f679674
simplify
CyrusNajmabadi Mar 13, 2021
acdb61f
simplify
CyrusNajmabadi Mar 13, 2021
4888740
simplify
CyrusNajmabadi Mar 13, 2021
1104c57
simplify
CyrusNajmabadi Mar 13, 2021
139af1c
simplify
CyrusNajmabadi Mar 13, 2021
a7f1f6d
reorder
CyrusNajmabadi Mar 13, 2021
c32939b
Simplify
CyrusNajmabadi Mar 13, 2021
85c85fe
Simplify
CyrusNajmabadi Mar 13, 2021
78b9472
Tighten logic
CyrusNajmabadi Mar 14, 2021
825a017
simplify
CyrusNajmabadi Mar 14, 2021
38714d3
simplify
CyrusNajmabadi Mar 14, 2021
0748faa
docs'
CyrusNajmabadi Mar 14, 2021
38ec737
doc comment
CyrusNajmabadi Mar 14, 2021
f1b2866
Simplify
CyrusNajmabadi Mar 14, 2021
463ee55
simplify
CyrusNajmabadi Mar 14, 2021
431fb56
Ignore case when checking for solution filter file extension
JoeRobich Mar 14, 2021
7cb77ec
Merge pull request #51854 from dotnet/main
Mar 14, 2021
29cbe4a
Fix variable names
JoeRobich Mar 14, 2021
dc91320
Disable embedded interop types on mac
davidwengier Mar 14, 2021
73e9858
Merge pull request #51872 from davidwengier/TurnOffEmbeddedTypes
Mar 15, 2021
0eac7d1
Simplify CSharpRequiredLanguageVersion (#51881)
Youssef1313 Mar 15, 2021
309de73
Check for empty project filter instead of null project filter.
JoeRobich Mar 15, 2021
d6a0ac2
Update dependencies from https://github.com/dotnet/roslyn build 20210…
dotnet-maestro[bot] Mar 15, 2021
773485b
Better rebuild logging (#51852)
jaredpar Mar 16, 2021
78287fa
Display effective language version for #error version (#51880)
Youssef1313 Mar 16, 2021
9e13da8
Ensure NullableWalker.SnapshotManager.ExitWalker() is invoked (#51851)
cston Mar 16, 2021
e26be83
Change Compilation.CommonSyntaxTrees to use ImmutableArray (#51905)
HurricanKai Mar 16, 2021
a5f9eff
Prefix fields with _ and make them private
jasonmalinowski Feb 26, 2021
7367def
Null annotate the SnippetExpansionClient
jasonmalinowski Feb 26, 2021
6243f78
Remove the ArgumentValue snippet function
jasonmalinowski Feb 27, 2021
9cbb690
Simplify state management in AbstractSnippetExpansionClient
jasonmalinowski Mar 4, 2021
e3913d1
Fix issue where typing after invoking the snippet may overwrite typing
jasonmalinowski Mar 4, 2021
65d7e29
Switch to SymbolEquivalenceComparer when comparing symbols
jasonmalinowski Mar 11, 2021
c7c1de0
Add tests to cover that parameter content isn't misinterpreted in XML
jasonmalinowski Mar 11, 2021
e931619
Add a workaround for an editor bug
jasonmalinowski Mar 11, 2021
73add9e
Merge pull request #51825 from JoeRobich/action-table-names
JoeRobich Mar 16, 2021
18df362
Respect options passed in by LSP in OnAutoInsertHandler
allisonchou Mar 16, 2021
c953000
Merge pull request #51655 from jasonmalinowski/argument-completion-tw…
jasonmalinowski Mar 16, 2021
51cb050
Cleanup
allisonchou Mar 16, 2021
cbfd697
Remove channel publishing and clean up PublishData
JoeRobich Mar 16, 2021
4eda7c8
Add comment about servicing branches
JoeRobich Mar 16, 2021
2a03760
Add Microsoft.CodeAnalysis.ExternalAccess.DotNetWatch to PublishData
JoeRobich Mar 17, 2021
ff31a40
Merge pull request #51925 from dotnet/dev/jorobich/add-package-to-pub…
JoeRobich Mar 17, 2021
7ecbf8a
Merge pull request #51918 from dotnet/dev/jorobich/cleanup-publishdata
JoeRobich Mar 17, 2021
c016e64
Rebuild compilations that use top-level statements (#51845)
RikkiGibson Mar 17, 2021
a6cfe5f
Fix Function Pointer RefKind Display (#51223)
YairHalberstadt Mar 17, 2021
b44e79e
Remove obsolete publishing step (#51465)
tmat Mar 17, 2021
a45d463
Cache expensive lookup that never changes over life of vs.
CyrusNajmabadi Mar 17, 2021
34ae31e
Merge pull request #51575 from dibarbet/update_queue_metrics
dibarbet Mar 17, 2021
9ee86a3
Merge pull request #51916 from allisonchou/LSPOnAutoInsertSettings
allisonchou Mar 17, 2021
d0e732d
Only update snippet model on explicit selection
sharwell Mar 18, 2021
7ae8d6f
Fix detection of full method call snippets in FormatSpan
sharwell Mar 18, 2021
b3b58fe
Remove unnecessary null check
sharwell Mar 18, 2021
c18da5a
Fix parameter casing (#51939)
Youssef1313 Mar 18, 2021
4cdd05a
Add tests for previously problematic behaviors
sharwell Mar 18, 2021
431a265
Document sentinel field
sharwell Mar 18, 2021
83a95f0
Avoid exceptions for snippets not containing Description nodes
sharwell Mar 18, 2021
99861b0
Merge pull request #51943 from CyrusNajmabadi/cacheComponentModel
CyrusNajmabadi Mar 18, 2021
77920cd
Fix rebuild round trip in unit tests (#51877)
jaredpar Mar 18, 2021
ca4565b
Fix links (#51796)
Youssef1313 Mar 18, 2021
76f905f
Merge pull request #51557 from sharwell/rm-validation
sharwell Mar 18, 2021
b28fcc6
Merge pull request #51948 from sharwell/explicit-switch
sharwell Mar 18, 2021
59df272
Move code back from quick info to SymbolDisplay.
CyrusNajmabadi Mar 18, 2021
63a5fd8
Revert
CyrusNajmabadi Mar 18, 2021
4b50f66
Simplify
CyrusNajmabadi Mar 18, 2021
ad668af
Fix a build break (#51963)
jaredpar Mar 18, 2021
0178caf
Merge remote-tracking branch 'upstream/main' into metadataLockign
CyrusNajmabadi Mar 18, 2021
cccbf8d
Remove capture.
CyrusNajmabadi Mar 18, 2021
fab5c7e
Merge remote-tracking branch 'upstream/main' into symbolDisplay
CyrusNajmabadi Mar 18, 2021
8eaa63a
Update resources
sharwell Mar 18, 2021
c9ceab5
Rename file to match type name
sharwell Mar 18, 2021
2ce475b
Simplify MEF construction
sharwell Mar 18, 2021
fce2971
Remove unused base class
sharwell Mar 18, 2021
048cdde
Revert unnecessary changes
sharwell Mar 18, 2021
00f8b74
Fix and enable tests
sharwell Mar 18, 2021
cdfa829
Add local functions
CyrusNajmabadi Mar 18, 2021
46ff643
Add docs
CyrusNajmabadi Mar 18, 2021
30b76f5
Merge remote-tracking branch 'upstream/main' into intellisenseExplici…
CyrusNajmabadi Mar 18, 2021
3819516
Add docs
CyrusNajmabadi Mar 18, 2021
8265eaa
Whitespace
CyrusNajmabadi Mar 18, 2021
4b79520
Update src/Features/CSharp/Portable/Completion/CompletionProviders/Op…
CyrusNajmabadi Mar 18, 2021
ffcd9f4
Update src/Features/CSharp/Portable/Completion/CompletionProviders/Op…
CyrusNajmabadi Mar 18, 2021
621b4b1
rename
CyrusNajmabadi Mar 18, 2021
bd6ee53
Merge branch 'intellisenseExplicitCast' of https://github.com/MaStr11…
CyrusNajmabadi Mar 18, 2021
704dcff
Update src/Workspaces/CSharp/Portable/Recommendations/CSharpRecommend…
CyrusNajmabadi Mar 18, 2021
9c08521
Tests for EditorBrowsable for indexers
MaStr11 Mar 18, 2021
f7627d1
Test indexer is suggested on strings
MaStr11 Mar 18, 2021
84ee17d
FIx editor browsable
CyrusNajmabadi Mar 18, 2021
c4d2dd9
Fix formatting
sharwell Mar 18, 2021
f29e223
Add test for EditorBrowsable on operators
MaStr11 Mar 18, 2021
01bc741
Add tests for EditorBrowsable on conversions
MaStr11 Mar 18, 2021
9aedb96
Merge pull request #51780 from dotnet/dev/jmarolf/fix-link
Mar 18, 2021
04adc58
Update SymbolEqualityComparer.IncludeNullability docs (#51724)
Youssef1313 Mar 19, 2021
37cb7f8
Merge pull request #48092 from paul1956/VBCodeCleanup
sharwell Mar 19, 2021
a876a4b
Merge pull request #51960 from dotnet/features/argument-completion
sharwell Mar 19, 2021
230fa87
Merge pull request #51747 from CyrusNajmabadi/metadataLockign
Mar 19, 2021
53bbfad
Fix cancellation handling in GetAssetsAsync
sharwell Mar 19, 2021
69c2b86
Fix cancellation handling in TryReadDiagnosticData
sharwell Mar 19, 2021
595de20
Merge pull request #51850 from sharwell/small-perf-fixes
sharwell Mar 19, 2021
566dfa5
Merge pull request #51976 from sharwell/fix-cancellation
Mar 19, 2021
3310b7d
PR Feedback
davidwengier Mar 19, 2021
b71d313
do not add if empty
CyrusNajmabadi Mar 19, 2021
76db5f8
Order attributes
CyrusNajmabadi Mar 19, 2021
cbc91ec
Update RemoveUnnecessaryCastTests.cs
Youssef1313 Mar 19, 2021
41c29a5
Update RemoveUnnecessaryCastTests.cs
Youssef1313 Mar 19, 2021
f1e11ff
Merge pull request #51985 from Youssef1313/unskip
sharwell Mar 19, 2021
f7ad214
Fix additional cancellation case for GetAssetsAsync
sharwell Mar 19, 2021
150ee54
Merge pull request #51507 from davidwengier/EscapeResourceStringBefor…
Mar 19, 2021
8cdc029
Add compiler support for UnconditionalSuppressMessage (#51792)
agocke Mar 19, 2021
70fd26c
Ensure lambdas under target-typed contexts are always visited in null…
333fred Mar 11, 2021
1b41b62
Do not cache switch governing expression bound nodes in the binder, a…
333fred Mar 11, 2021
5d5a5f4
Enable bootstrap build on build correctness leg.
333fred Mar 19, 2021
dafd1b8
Skip unconverted object creation expressions in the debug verifier.
333fred Mar 19, 2021
edec40d
Use longer timeout for interactive window tests
sharwell Mar 19, 2021
7493674
Rename
CyrusNajmabadi Mar 19, 2021
daa5f1d
Merge pull request #51990 from sharwell/fix-cancellation
Mar 19, 2021
362f3b0
Merge branch 'intellisenseExplicitCast' of https://github.com/MaStr11…
CyrusNajmabadi Mar 19, 2021
ff512d2
Merge pull request #47511 from MaStr11/intellisenseExplicitCast
Mar 19, 2021
632aa38
Add feature flag so we can remotely disable operator-completion.
CyrusNajmabadi Mar 19, 2021
33dd9ab
Merge pull request #51782 from JoeRobich/solution-filter-support
JoeRobich Mar 19, 2021
75700f5
Merge remote-tracking branch 'upstream/main' into symbolDisplay
CyrusNajmabadi Mar 19, 2021
717c48d
Update language feature status table (#51994)
333fred Mar 20, 2021
9f2d705
Merge pull request #51728 from huoyaoyuan/naming-extern
sharwell Mar 20, 2021
791d60f
Rename record equality parameters to 'left' and 'right' (#51973)
C-xC-c Mar 20, 2021
ad3ecc5
Merge pull request #51961 from CyrusNajmabadi/symbolDisplay
CyrusNajmabadi Mar 20, 2021
4a9d841
Merge pull request #52002 from CyrusNajmabadi/completionAB
CyrusNajmabadi Mar 20, 2021
451fa62
Merge pull request #52000 from sharwell/longer-timeout
Mar 20, 2021
b254587
Hot Reload watch service (#51967)
tmat Mar 22, 2021
942e5a4
Downgrade System.Text.Json reference version to 4.7.2
JoeRobich Mar 22, 2021
d2cf831
Add note about upgrading System.Text.Json
JoeRobich Mar 22, 2021
8f67fdc
Use absolute project paths when loading a Solution Filter
JoeRobich Mar 22, 2021
9ddf51f
Fix for: "Information Loss" caused by use of default in SyntaxNode-Up…
bernd5 Mar 22, 2021
b47625a
Merge pull request #52056 from JoeRobich/slnf-separators
JoeRobich Mar 22, 2021
7becc52
Simplify NotNullIfParameterNotNull implementation in PEParameterSymbo…
Youssef1313 Mar 23, 2021
672e565
Merge pull request #52055 from dotnet/dev/jorobich/downgrade-text-json
JoeRobich Mar 23, 2021
1b56a44
Add missing [Fact] in ConversionCompletionProviderTests
MaStr11 Mar 23, 2021
887150e
Obsolete ImportingConstructor
Youssef1313 Mar 23, 2021
5228f97
Initialize fields before registering event handlers
sharwell Mar 23, 2021
9552f01
Merge pull request #52073 from Youssef1313/patch-38
sharwell Mar 23, 2021
14cdeb2
Merge pull request #52071 from MaStr11/patch-2
sharwell Mar 23, 2021
f554f62
Make DocumentationCommentCompiler work after NormalizeWhitespace (#47…
svick Mar 23, 2021
06a421e
Update IOperation Test Hook Doc (#52062)
333fred Mar 23, 2021
c30efad
Fix parenthesized pattern parsing (#49621)
alrz Mar 23, 2021
d09f248
Revert "Make DocumentationCommentCompiler work after NormalizeWhitesp…
jaredpar Mar 23, 2021
9995cfd
Merge pull request #52088 from dotnet/revert-47360-normalizewhitespac…
jaredpar Mar 23, 2021
58e6128
Fix null annotation of SyntaxFactory.UsingStatement (#51984)
Youssef1313 Mar 23, 2021
ef50316
Merge pull request #52082 from sharwell/init-order
sharwell Mar 24, 2021
7859e2d
Consistent ContainsSyntaxTree behavior between VB and C# (#52050)
Youssef1313 Mar 24, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 7 additions & 0 deletions Compilers.sln
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Microsoft.CodeAnalysis.Coll
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Rebuild", "src\Compilers\Core\Rebuild\Rebuild.csproj", "{321F9FED-AACC-42CB-93E5-541D79E099E8}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild.UnitTests", "src\Compilers\Core\RebuildTest\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj", "{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
src\Analyzers\VisualBasic\CodeFixes\VisualBasicCodeFixes.projitems*{0141285d-8f6c-42c7-baf3-3c0ccd61c716}*SharedItemsImports = 5
Expand Down Expand Up @@ -473,6 +475,10 @@ Global
{321F9FED-AACC-42CB-93E5-541D79E099E8}.Debug|Any CPU.Build.0 = Debug|Any CPU
{321F9FED-AACC-42CB-93E5-541D79E099E8}.Release|Any CPU.ActiveCfg = Release|Any CPU
{321F9FED-AACC-42CB-93E5-541D79E099E8}.Release|Any CPU.Build.0 = Release|Any CPU
{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C}.Debug|Any CPU.Build.0 = Debug|Any CPU
{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C}.Release|Any CPU.ActiveCfg = Release|Any CPU
{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -549,6 +555,7 @@ Global
{432F4461-E198-44AA-8022-9E8C06A17C93} = {B20208C3-D3A6-4020-A274-6BE3786D29FB}
{E919DD77-34F8-4F57-8058-4D3FF4C2B241} = {3CDEA9FB-CD44-4AB4-98A8-5537AAA2169B}
{321F9FED-AACC-42CB-93E5-541D79E099E8} = {A41D1B99-F489-4C43-BBDF-96D61B19A6B9}
{FDBFBB64-5980-41C2-9E3E-FB8E2F700A5C} = {A41D1B99-F489-4C43-BBDF-96D61B19A6B9}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {6F599E08-A9EA-4FAA-897F-5D824B0210E6}
Expand Down
1 change: 1 addition & 0 deletions Compilers.slnf
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"src\\Compilers\\Core\\MSBuildTaskTests\\Microsoft.Build.Tasks.CodeAnalysis.UnitTests.csproj",
"src\\Compilers\\Core\\MSBuildTask\\Microsoft.Build.Tasks.CodeAnalysis.csproj",
"src\\Compilers\\Core\\Portable\\Microsoft.CodeAnalysis.csproj",
"src\\Compilers\\Core\\RebuildTest\\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj",
"src\\Compilers\\Core\\Rebuild\\Rebuild.csproj",
"src\\Compilers\\Extension\\Roslyn.Compilers.Extension.csproj",
"src\\Compilers\\Server\\VBCSCompilerTests\\VBCSCompiler.UnitTests.csproj",
Expand Down
14 changes: 7 additions & 7 deletions Roslyn.sln
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.CSha
EndProject
Project("{778DAE3C-4631-46EA-AA77-85C1314464D9}") = "Microsoft.CodeAnalysis.VisualBasic.CodeStyle.UnitTests", "src\CodeStyle\VisualBasic\Tests\Microsoft.CodeAnalysis.VisualBasic.CodeStyle.UnitTests.vbproj", "{E512C6C1-F085-4AD7-B0D9-E8F1A0A2A510}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RoslynPublish", "src\Tools\RoslynPublish\RoslynPublish.csproj", "{2D36C343-BB6A-4CB5-902B-E2145ACCB58F}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.EditorFeatures.Wpf", "src\EditorFeatures\Core.Wpf\Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj", "{FFB00FB5-8C8C-4A02-B67D-262B9D28E8B1}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AnalyzerRunner", "src\Tools\AnalyzerRunner\AnalyzerRunner.csproj", "{60166C60-813C-46C4-911D-2411B4ABBC0F}"
Expand Down Expand Up @@ -487,6 +485,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Coll
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Rebuild", "src\Compilers\Core\Rebuild\Rebuild.csproj", "{B7D29559-4360-434A-B9B9-2C0612287999}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Rebuild.UnitTests", "src\Compilers\Core\RebuildTest\Microsoft.CodeAnalysis.Rebuild.UnitTests.csproj", "{21B49277-E55A-45EF-8818-744BCD6CB732}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
src\Analyzers\VisualBasic\CodeFixes\VisualBasicCodeFixes.projitems*{0141285d-8f6c-42c7-baf3-3c0ccd61c716}*SharedItemsImports = 5
Expand Down Expand Up @@ -1066,10 +1066,6 @@ Global
{E512C6C1-F085-4AD7-B0D9-E8F1A0A2A510}.Debug|Any CPU.Build.0 = Debug|Any CPU
{E512C6C1-F085-4AD7-B0D9-E8F1A0A2A510}.Release|Any CPU.ActiveCfg = Release|Any CPU
{E512C6C1-F085-4AD7-B0D9-E8F1A0A2A510}.Release|Any CPU.Build.0 = Release|Any CPU
{2D36C343-BB6A-4CB5-902B-E2145ACCB58F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{2D36C343-BB6A-4CB5-902B-E2145ACCB58F}.Debug|Any CPU.Build.0 = Debug|Any CPU
{2D36C343-BB6A-4CB5-902B-E2145ACCB58F}.Release|Any CPU.ActiveCfg = Release|Any CPU
{2D36C343-BB6A-4CB5-902B-E2145ACCB58F}.Release|Any CPU.Build.0 = Release|Any CPU
{FFB00FB5-8C8C-4A02-B67D-262B9D28E8B1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{FFB00FB5-8C8C-4A02-B67D-262B9D28E8B1}.Debug|Any CPU.Build.0 = Debug|Any CPU
{FFB00FB5-8C8C-4A02-B67D-262B9D28E8B1}.Release|Any CPU.ActiveCfg = Release|Any CPU
Expand Down Expand Up @@ -1266,6 +1262,10 @@ Global
{B7D29559-4360-434A-B9B9-2C0612287999}.Debug|Any CPU.Build.0 = Debug|Any CPU
{B7D29559-4360-434A-B9B9-2C0612287999}.Release|Any CPU.ActiveCfg = Release|Any CPU
{B7D29559-4360-434A-B9B9-2C0612287999}.Release|Any CPU.Build.0 = Release|Any CPU
{21B49277-E55A-45EF-8818-744BCD6CB732}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{21B49277-E55A-45EF-8818-744BCD6CB732}.Debug|Any CPU.Build.0 = Debug|Any CPU
{21B49277-E55A-45EF-8818-744BCD6CB732}.Release|Any CPU.ActiveCfg = Release|Any CPU
{21B49277-E55A-45EF-8818-744BCD6CB732}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -1415,7 +1415,6 @@ Global
{9FF1205F-1D7C-4EE4-B038-3456FE6EBEAF} = {DC014586-8D07-4DE6-B28E-C0540C59C085}
{5018D049-5870-465A-889B-C742CE1E31CB} = {DC014586-8D07-4DE6-B28E-C0540C59C085}
{E512C6C1-F085-4AD7-B0D9-E8F1A0A2A510} = {DC014586-8D07-4DE6-B28E-C0540C59C085}
{2D36C343-BB6A-4CB5-902B-E2145ACCB58F} = {FD0FAF5F-1DED-485C-99FA-84B97F3A8EEC}
{FFB00FB5-8C8C-4A02-B67D-262B9D28E8B1} = {EE97CB90-33BB-4F3A-9B3D-69375DEC6AC6}
{60166C60-813C-46C4-911D-2411B4ABBC0F} = {FD0FAF5F-1DED-485C-99FA-84B97F3A8EEC}
{FC2AE90B-2E4B-4045-9FDD-73D4F5ED6C89} = {C2D1346B-9665-4150-B644-075CF1636BAA}
Expand Down Expand Up @@ -1488,6 +1487,7 @@ Global
{E919DD77-34F8-4F57-8058-4D3FF4C2B241} = {C2D1346B-9665-4150-B644-075CF1636BAA}
{0C2E1633-1462-4712-88F4-A0C945BAD3A8} = {C2D1346B-9665-4150-B644-075CF1636BAA}
{B7D29559-4360-434A-B9B9-2C0612287999} = {A41D1B99-F489-4C43-BBDF-96D61B19A6B9}
{21B49277-E55A-45EF-8818-744BCD6CB732} = {A41D1B99-F489-4C43-BBDF-96D61B19A6B9}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {604E6B91-7BC0-4126-AE07-D4D2FEFC3D29}
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines-official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ stages:
displayName: Publish Assets
inputs:
filePath: 'eng\publish-assets.ps1'
arguments: '-configuration $(BuildConfiguration) -branchName "$(SourceBranchName)" -gitHubUserName $(Roslyn.GitHubUserName) -gitHubToken $(AccessToken-dotnet-build-bot-public-repo) -gitHubEmail $(Roslyn.GitHubEmail)'
arguments: '-configuration $(BuildConfiguration) -branchName "$(SourceBranchName)"'
condition: and(succeeded(), eq(variables['PRNumber'], 'default'))

# Publish OptProf configuration files
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ jobs:
steps:
- template: eng/pipelines/checkout-unix-task.yml

- script: ./eng/cibuild.sh --configuration Debug --prepareMachine --docker --sourceBuild
- script: ./eng/cibuild.sh --configuration Debug --prepareMachine --binaryLog --sourceBuild
displayName: Build

- template: eng/pipelines/publish-logs.yml
Expand Down
4 changes: 2 additions & 2 deletions docs/Language Feature Status.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ efforts behind them.
| [Improved Definite Assignment](https://github.com/dotnet/csharplang/issues/4465) | [improved-definite-assignment](https://github.com/dotnet/roslyn/tree/features/improved-definite-assignment) | [In Progress](https://github.com/dotnet/roslyn/issues/51463) | [RikkiGibson](https://github.com/RikkiGibson) | [jcouv](https://github.com/jcouv) | [jaredpar](https://github.com/jaredpar) |
| [Relax ordering of `ref` and `partial` modifiers](https://github.com/dotnet/csharplang/issues/946) | [ref-partial](https://github.com/dotnet/roslyn/tree/features/ref-partial) | In Progress | [alrz](https://github.com/alrz) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
| [Parameter null-checking](https://github.com/dotnet/csharplang/issues/2145) | [param-nullchecking](https://github.com/dotnet/roslyn/tree/features/param-nullchecking) | [In Progress](https://github.com/dotnet/roslyn/issues/36024) | [fayrose](https://github.com/fayrose) | [agocke](https://github.com/agocke) | [jaredpar](https://github.com/jaredpar) |
| [Caller expression attribute](https://github.com/dotnet/csharplang/issues/287) | [caller-expression](https://github.com/dotnet/roslyn/tree/features/caller-expression) | Prototype | [alrz](https://github.com/alrz) | [jcouv](https://github.com/jcouv) | [jcouv](https://github.com/jcouv) |
| [Caller expression attribute](https://github.com/dotnet/csharplang/issues/287) | [caller-argument-expression](https://github.com/dotnet/roslyn/tree/features/caller-argument-expression) | Prototype | [Youssef1313](https://github.com/Youssef1313) | [333fred](https://github.com/333fred),[jcouv](https://github.com/jcouv) | [jcouv](https://github.com/jcouv) |
| [Generic attributes](https://github.com/dotnet/csharplang/issues/124) | [generic-attributes](https://github.com/dotnet/roslyn/tree/features/generic-attributes) | [In Progress](https://github.com/dotnet/roslyn/issues/36285) | [AviAvni](https://github.com/AviAvni) | [agocke](https://github.com/agocke) | [mattwar](https://github.com/mattwar) |
| [Default in deconstruction](https://github.com/dotnet/roslyn/pull/25562) | [decon-default](https://github.com/dotnet/roslyn/tree/features/decon-default) | [Implemented](https://github.com/dotnet/roslyn/issues/25559) | [jcouv](https://github.com/jcouv) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
| [Constant Interpolated Strings](https://github.com/dotnet/csharplang/issues/2951) | main | [Merged into 16.9p3](https://github.com/dotnet/roslyn/pull/49676) | [kevinsun-dev](https://github.com/kevinsun-dev) | [333fred](https://github.com/333fred) | [jaredar](https://github.com/jaredpar), [agocke](https://github.com/agocke) |
| [Mix declarations and variables in deconstruction](https://github.com/dotnet/csharplang/issues/125) | main | [Merged into 16.10](https://github.com/dotnet/roslyn/issues/47746) | [YairHalberstadt ](https://github.com/YairHalberstadt) | [jcouv](https://github.com/jcouv) | [MadsTorgersen](https://github.com/MadsTorgersen) |
| [List patterns](https://github.com/dotnet/csharplang/issues/3435) | [list-patterns](https://github.com/dotnet/roslyn/tree/features/list-patterns) | [In Progress](https://github.com/dotnet/roslyn/issues/51289) | [alrz](https://github.com/alrz) | [333fred](https://github.com/333fred) (tentative) | [333fred](https://github.com/333fred) |
| [List patterns](https://github.com/dotnet/csharplang/issues/3435) | [list-patterns](https://github.com/dotnet/roslyn/tree/features/list-patterns) | [In Progress](https://github.com/dotnet/roslyn/issues/51289) | [alrz](https://github.com/alrz) | [jcouv](https://github.com/jcouv), [333fred](https://github.com/333fred) | [333fred](https://github.com/333fred) |

# VB 16.9

Expand Down
36 changes: 36 additions & 0 deletions docs/compilers/CSharp/Compiler Breaking Changes - post DotNet 5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
## This document lists known breaking changes in Roslyn after .NET 5.

1. https://github.com/dotnet/roslyn/issues/46044 In C# 9.0 (Visual Studio 16.9), a warning is reported when assigning `default` to, or when casting a possibly `null` value to a type parameter type that is not constrained to value types or reference types. To avoid the warning, the type can be annotated with `?`.
```C#
static void F1<T>(object? obj)
{
T t1 = default; // warning CS8600: Converting possible null value to non-nullable type
t1 = (T)obj; // warning CS8600: Converting possible null value to non-nullable type

T? t2 = default; // ok
t2 = (T?)obj; // ok
}
```

2. https://github.com/dotnet/roslyn/pull/50755 In .NET 5.0.200 (Visual Studio 16.9), if there is a common type between the two branches of a conditional expression, that type is the type of the conditional expression.

This is a breaking change from 5.0.103 (Visual Studio 16.8) which due to a bug incorrectly used the target type of the conditional expression as the type even if there was a common type between the two branches.

This latest change aligns the compiler behavior with the C# specification and with versions of the compiler before .NET 5.0.
```C#
static short F1(bool b)
{
// 16.7, 16.9 : CS0266: Cannot implicitly convert type 'int' to 'short'
// 16.8 : ok
// 16.8 -langversion:8 : CS8400: Feature 'target-typed conditional expression' is not available in C# 8.0
return b ? 1 : 2;
}

static object F2(bool b, short? a)
{
// 16.7, 16.9 : int
// 16.8 : short
// 16.8 -langversion:8 : CS8400: Feature 'target-typed conditional expression' is not available in C# 8.0
return a ?? (b ? 1 : 2);
}
```
2 changes: 1 addition & 1 deletion docs/compilers/CSharp/Unicode Version.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ The Roslyn compilers depend on the underlying platform for their Unicode behavio
For example, the Unicode Katakana Middle Dot "・" (U+30FB) no longer works in identifiers in C# 6.
Its Unicode class was Pc (Punctuation, Connector) in Unicode 5.1 or older, but it changed to Po (Punctuation, Other) in Unicode 6.0.

See also https://github.com/ufcpp/UfcppSample/blob/main/BreakingChanges/VS2015_CS6/KatakanaMiddleDot.cs
See also https://github.com/ufcpp/UfcppSample/blob/master/BreakingChanges/VS2015_CS6/KatakanaMiddleDot.cs
4 changes: 3 additions & 1 deletion docs/compilers/IOperation Test Hook.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ before merging to production.

In order to replicate test failures, there are 2 options:

1. Uncomment `src/Compilers/Test/Core/Compilation/Compilation.cs:7`, which defines `ROSLYN_TEST_IOPERATION`, and run your tests. Do _not_ check this in, as it
1. Uncomment `src/Compilers/Test/Core/Compilation/CompilationExtensions.cs:7`, which defines `ROSLYN_TEST_IOPERATION`, and run your tests. Do _not_ check this in, as it
will enable the test hook for every test in every project and significantly slow down regular test runs.
2. Set the `ROSLYN_TEST_IOPERATION` environment variable and restart VS with it set.
3. Set a breakpoint at the start of `ValidateIOperations`, in `src/Compilers/Test/Core/Compilation/CompilationExtensions.cs`. When it breaks, use VS's jump to location or
drag the instruction pointer past the early check and return on `EnableVerifyIOperation`, which will run the code for the current test run.

In either case, after this has been done all tests will run the hook as part of running the test, and you can set breakpoints as normal. It is often helpful to
run until an exception has been hit and then see what nodes were being processed, as most tests have multiple methods and understanding the specific context is
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/Nullable Annotations.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This document describes how nullable annotations should be approached in the
Roslyn code base. The default is to simply follow [the same guidance](https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/api-guidelines/nullability.md)
as the [dotnet/runtime](github.com/dotnet/runtime) repository. This document
as the [dotnet/runtime](https://github.com/dotnet/runtime) repository. This document
serves to detail the places where the guidance differs for Roslyn and
re-emphasize rules that come up frequently.

Expand Down
2 changes: 1 addition & 1 deletion docs/wiki/C#-Interactive-Walkthrough.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
This walkthrough is a beginner's guide to learning basic interactive concepts and how to navigate the C# Interactive Window. To learn more about the Interactive window, watch [this video](channel9.msdn.com/Events/Visual-Studio/Connect-event-2015/103) or check out [our documentation](https://github.com/dotnet/roslyn/blob/main/docs/wiki/Interactive-Window.md).
This walkthrough is a beginner's guide to learning basic interactive concepts and how to navigate the C# Interactive Window. To learn more about the Interactive window, watch [this video](https://channel9.msdn.com/Events/Visual-Studio/Connect-event-2015/103) or check out [our documentation](https://github.com/dotnet/roslyn/blob/main/docs/wiki/Interactive-Window.md).

*Note*: This walkthrough is adapted from [Bill Chiles](https://github.com/billchi-ms)' original. Thanks, Bill!

Expand Down
12 changes: 6 additions & 6 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
<ProductDependencies>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.21118.7">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.21161.1">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>4957a6f3dd5f6fd1ca9ff06f9c50402f2e3b17e8</Sha>
<Sha>9467b1074927ee3fe98d539d3b72f5686c861958</Sha>
</Dependency>
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.10.0-2.21151.4">
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.10.0-2.21165.4">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>c933ed58c3edd70916d2fd676db49c40035b5cac</Sha>
<Sha>1cd20fc1f0990bb03fd9b9577ce835a429c31b06</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="2.0.0-beta.21118.7">
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="2.0.0-beta.21161.1">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>4957a6f3dd5f6fd1ca9ff06f9c50402f2e3b17e8</Sha>
<Sha>9467b1074927ee3fe98d539d3b72f5686c861958</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
Loading