Merge 'main' into 'features/GlobalUsingDirective' #52098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-release/dev16.10 Merge release/dev16.9-vs-deps to release/dev16.10
…tion-branch Merge main into featuers/argument-completion
…release/dev16.10-to-main
This changes our code to use the RTM version of the framework reference assemblies rather than preview. The RTM version though forces a reference to Microsoft.VisualBasic.dll when building VB projects. That caused a compilation error in part of our code because of the following pattern ```vb For Each str in strings ``` In VB the identifier in the `For Each` is not necessarily a new declaration but can also refer to existing identifiers. Hence this name must go through standard name lookup. Once the reference to Microsoft.VisualBasic.dll is added the `Microsoft.VisualBasic.Conversions` module becomes available and the method `Str` in that module is now a valid top level name. This causes the above code to stop compiling. Fix is to use a non-conflicting identifier. closes #517711
Cancel outstanding work on tagger disconnect
Use longer timeout for interactive window tests
Use absolute project paths when loading a Solution Filter
Downgrade System.Text.Json reference version to 4.7.2
Follow up to #47511 I missed placing the `[Fact]` attribute on one test method. @CyrusNajmabadi
Fixes a NullReferenceException in DocumentFileChangeContext_FileChanged observed in local debugging.
Obsolete ImportingConstructor
Add missing [Fact] in ConversionCompletionProviderTests
…e-xmlcomments Revert "Make DocumentationCommentCompiler work after NormalizeWhitespace"
Initialize fields before registering event handlers
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.