Rename Basic to Visual Basic in Visual Studio options page #53134
Conversation
Youssef1313
changed the title
Youssef1313
force-pushed
the
patch-31
branch
2 times, most recently
from
a25610d
to
f5a266f
Compare
|
@jasonmalinowski Can we get this merged? Thanks! |
jinujoseph
added
the
Community
|
@Youssef1313 Thanks for the ping; restarted our tests here since the previous runs were most stale. |
|
Also @Youssef1313 this will be probably a few days to merge since this may have quite the impact on things like documentation. For example, our docs team internally pointed out that pressing F1 when you're on our VB pages takes you to https://docs.microsoft.com/en-us/visualstudio/ide/reference/options-text-editor-basic-visual-basic?view=vs-2022 so we need to make sure that doesn't break either. |
|
@jasonmalinowski This should be easy enough to fix if it broke. Would you be able to check if it's broke? I won't be able to run RoslynDeployment at the moment unfortunately. If it broke, we should be able to capture the new f1_keyword and add it to the article metadata. |
|
@jasonmalinowski I tested and it seems that F1 isn't broken. It's still using "Basic" |
| <ProvideLanguageEditorOptionPage(GetType(AdvancedOptionPage), "Basic", Nothing, "Advanced", "#102", 10160)> | ||
| <ProvideLanguageEditorToolsOptionCategory("Basic", "Code Style", "#109")> | ||
| <ProvideLanguageEditorOptionPage(GetType(CodeStylePage), "Basic", "Code Style", "General", "#111", 10161)> |
There was a problem hiding this comment.
Probably this is why F1 is still working.
There was a problem hiding this comment.
Yeah, I guess the platform is just producing a string based on the underlying key names. I tried to do a bit of digging to figure out where that lived but didn't find it quickly enough.
|
@Youssef1313 Hmm, I guess maybe some extra debugging in in order, but it may use the underlying language name since the display name would be subject to localization. And thanks for testing, I guess I'll remove that for my list for today. 😄 As far as this PR I have to chase a bit more internally to make sure we're ready for the more general documentation impact on this, since even if F1 works we will have other pages that at least need to have content updated. |
|
@jasonmalinowski Any updates? |
|
@Youssef1313 Thanks for the reminder -- just poked the internal teams and I think we're mostly good, just waiting for a confirmation. |
|
OK, internal teams are good; just going to give this one more CI run since it's a bit stale. |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ghost
added this to the
|
Merged, thanks for the change @Youssef1313! |
This does the first point of the design meeting notes in #34990 (comment).