Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Basic to Visual Basic in Visual Studio options page #53134

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Rename Basic to Visual Basic in Visual Studio options page #53134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0874a50
Rename 'Basic' to 'Visual Basic' in Visual Studio options page
Youssef1313 May 14, 2021
e2a7774
Update comments per feedback
Youssef1313 May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/VisualStudio/VisualBasic/Impl/LanguageService/VisualBasicPackage.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ Namespace Microsoft.VisualStudio.LanguageServices.VisualBasic
' The option page configuration is duplicated in PackageRegistration.pkgdef.
Youssef1313 marked this conversation as resolved.
Show resolved Hide resolved
'
' VB option pages tree
' Basic
' Visual Basic
' General (from editor)
' Scroll Bars (from editor)
' Tabs (from editor)
' Advanced
Youssef1313 marked this conversation as resolved.
Show resolved Hide resolved
' Code Style (category)
' General
' Naming
' IntelliSense
<ProvideLanguageEditorOptionPage(GetType(AdvancedOptionPage), "Basic", Nothing, "Advanced", "#102", 10160)>
<ProvideLanguageEditorToolsOptionCategory("Basic", "Code Style", "#109")>
<ProvideLanguageEditorOptionPage(GetType(CodeStylePage), "Basic", "Code Style", "General", "#111", 10161)>
Comment on lines 35 to 37
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is why F1 is still working.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess the platform is just producing a string based on the underlying key names. I tried to do a bit of digging to figure out where that lived but didn't find it quickly enough.

Expand Down
6 changes: 4 additions & 2 deletions src/VisualStudio/VisualBasic/Impl/PackageRegistration.pkgdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,16 @@
// The option page configuration is duplicated on VisualBasicPackage type definition.
//
// VB option pages tree
// Basic
// Visual Basic
// General (from editor)
// Scroll Bars (from editor)
// Tabs (from editor)
// Advanced
// Code Style (category)
// General
// Naming
// IntelliSense


[$RootKey$\Languages\Language Services\Basic\EditorToolsOptions\IntelliSense]
@="#112"
Expand Down Expand Up @@ -167,7 +169,7 @@
[$RootKey$\Languages\Language Services\Basic]
@="{e34acdc0-baae-11d0-88bf-00a0c9110049}"
"Package"="{574fc912-f74f-4b4e-92c3-f695c208a2bb}"
"LangResID"=dword:00000000
"LangResID"=dword:00000065

"DefaultToInsertSpaces"=dword:00000001
"EnableAdvancedMembersOption"=dword:00000001
Expand Down