Merge main into features/struct-ctors
#55037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further FAR simplifications
Additional cleanup to FAR engine.
…-main Merge release/dev17.0 to main
AdornmentManager Abstraction
Definite assignment, initial nullable, IOperation, and some cleanup
* upstream/main: (559 commits) Remove a few unused error codes (dotnet#54663) Use specific error message for wrong arity in async builder (dotnet#54632) Update azure-pipelines-richnav.yml (dotnet#54662) Capture file content on open instead of save (dotnet#54643) Add docs Further FAR simplifications Handle enhanced #line directive in DirectiveTriviaSyntax.DirectiveNameToken (dotnet#54636) move server name outside of loop Fix functionid Reduce telemetry output from find document in workspace Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) Feedback Ensure we don't try and build an empty table when modifying entries with no values (dotnet#54639) No need to specialized logic for determining set of projects to search Defer group computation till reporting time Handle FAR for global suppressions in a consistent fashion Update status for enhanced `#line` directive (dotnet#54581) Split IOperationTests into one part per type [LSP] Revert semantic tokens change in main (dotnet#54570) Add exceptionutilities unreachable to catch blocks that should not be hit ...
Capture file content on open instead of save (dotnet#54643)
…ginZoomLevelFix Make Inheritance Margin Zoom Level is divided by 100
…ceNameCompletion Fix 'name completion' with file scoped namespaces
…ation Remove dependency on Type.IsSerializable from OptionSet serialization
Don't combine 'this.' with underscore named fields
…eSortUsings Fix 'group usings' with file scoped namespaces
…eAddUsing Fix 'add extern alias' with file scoped namespaces
[main] Update dependencies from dotnet/source-build
* Pull Members Up adds Usings/Imports Add symbol annotations so that members pulled up will also include correct usings/imports. Add 12 new C# tests regarding pulling members up and import adding. * Change way to add symbol annotations, add test importing System.Linq and non-declared type * Working on adding using statements, tests failing * converted to language service to filter syntaxnode types, added more tests * Removed VB as there is no refactoring provider, passing tests * Remove add line to first member as elastic trivia already adds those lines * Re-added space for first member, only in case of no imports remaining in destination file * Fixed first member leading trivia and added a few comment tests, should just keep all leading trivia now. * Fixed line spacing issue * Updated to use syntax factory equivalence instead of just name equivalence, removed Distinct call, and refactored some language-agnostic code into abstract class as a private method * Remove unneccessary import * Refactored more functionality into abstract provider, added context node for namespace imports and added namespace & alias tests. * Update src/Features/Core/Portable/PullMemberUp/IMembersPullerService.cs Remove extra angle bracket. I thought I had done this, it must have been reverted somehow. Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> * WIP * More refactoring, now adds imports for all containing namespaces, add more tests too for namespaces, aliases, and extensions. * Added documentation, changed namespace import generation, added nested namespace import test. * Reverted some line change tests, failing now because the formatter deleted a line that should probably stay there. * Replaced all trivia from source imports with elastic line trivia. Fixed an error with duplicating first member trivia. Fixed tests that expected duplicate first member trivia. * Removed initial whitespace line on moved imports as it forced extra newlines when they weren't necessary. * Refactor import getting into syntax facts, revert names/services back to before + refactor service usages * Rename in syntaxfacts to handle file scoped namespaces, add test to make sure we find those namespaces. Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
…release/dev16.11-to-release/dev17.0
…o-release/dev17.0 Merge release/dev16.11 to release/dev17.0
…-main Merge release/dev17.0 to main
cston
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the usual minor conflicts (error codes, message ids, resources).
Test plan: #51698