Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CallerArgumentExpression to VB language feature status doc #55230

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add CallerArgumentExpression to VB language feature status doc #55230

merged 1 commit into from
Oct 12, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 29, 2021 •
edited
Loading

You may want to wait until the feature flag is removed.

@jcouv
Copy link
Member

jcouv commented Jul 29, 2021

You may want to wait until the feature flag is removed.

Yes. Let's do both in one go (in a couple of weeks).

@Youssef1313 Youssef1313 marked this pull request as draft July 29, 2021 18:06
@Youssef1313 Youssef1313 marked this pull request as ready for review September 25, 2021 06:34
@Youssef1313
Copy link
Member Author

@jcouv I forgot about this. The feature flag was removed in #55841.

@Youssef1313
Copy link
Member Author

Ping @jcouv

@jcouv jcouv self-assigned this Oct 12, 2021
@jcouv jcouv merged commit 5a9c518 into dotnet:main Oct 12, 2021
@ghost ghost added this to the Next milestone Oct 12, 2021
@jcouv
Copy link
Member

jcouv commented Oct 12, 2021

Thanks
It'd be good to add it here as well if you don't mind: https://github.com/dotnet/vblang/blob/main/Language-Version-History.md

Here's the C# equivalent for reference: https://github.com/dotnet/csharplang/blob/main/Language-Version-History.md#c-100---net-6-and-visual-studio-2022-version-170

@Youssef1313
Copy link
Member Author

@jcouv Sorry I had slipped this for a while. I just noticed we're not actually gating the new feature under a language version. So it's a feature for "compiler that shipped with VS 17.0 rather than a feature for VB 17 (there is no VB 17). The documents we have are about "language versions". Any ideas?

@Youssef1313 Youssef1313 deleted the patch-12 branch October 22, 2021 10:37
@Youssef1313
Copy link
Member Author

dotnet/vblang#609 Does this look good?

@RikkiGibson RikkiGibson modified the milestones: Next, 17.1.P1 Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Documentation
Projects
None yet
Milestone
17.1.P1
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @jcouv @RikkiGibson