Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CallerArgumentExpression feature flag #55841

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Remove CallerArgumentExpression feature flag #55841

merged 2 commits into from
Aug 24, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 24, 2021 •
edited by jcouv
Loading

Relates to test plan #52745

@Youssef1313 Youssef1313 requested a review from a team as a code owner August 24, 2021 05:10
@Youssef1313 Youssef1313 mentioned this pull request Aug 24, 2021
Closed
333fred
333fred approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Aug 24, 2021 •
edited
Loading 

        Dim compilation = CreateCompilation(source, targetFramework:=TargetFramework.NetCoreApp, references:={Net451.MicrosoftVisualBasic}, options:=TestOptions.ReleaseExe, parseOptions:=TestOptions.RegularLatest.WithFeature("CallerArgumentExpression"))

It feels like all references to the feature should be removed. #Closed

Refers to: src/Compilers/VisualBasic/Test/Emit/Attributes/AttributeTests_CallerArgumentExpression.vb:33 in 7cd5ceb. [](commit_id = 7cd5ceb, deletion_comment = False)

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

AlekseyTs
AlekseyTs approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@333fred 333fred merged commit 87f6fdf into dotnet:main Aug 24, 2021
@ghost ghost added this to the Next milestone Aug 24, 2021
@333fred
Copy link
Member

333fred commented Aug 24, 2021

Thanks @Youssef1313! 🎉

@Youssef1313 Youssef1313 deleted the caller-expr-feat-flag branch August 25, 2021 05:56
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
@Youssef1313 Youssef1313 mentioned this pull request Sep 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - CallerArgumentExpressionAttribute
Projects
None yet
Milestone
17.0.P4
Development

Successfully merging this pull request may close these issues.
5 participants
@Youssef1313 @AlekseyTs @333fred @dibarbet @jcouv