Remove user facing option around async-lightbulbs (17.1 and up only)

src/EditorFeatures/Core.Wpf/Suggestions/SuggestedActionsSourceProvider.cs

@@ -90,11 +90,9 @@ public SuggestedActionsSourceProvider(
             if (textBuffer.IsInLspEditorContext())
                 return null;
 
-            var asyncEnabled = _globalOptions.GetOption(SuggestionsOptions.Asynchronous) ?? !_globalOptions.GetOption(SuggestionsOptions.AsynchronousQuickActionsDisableFeatureFlag);
-
-            return asyncEnabled
-                ? new AsyncSuggestedActionsSource(_threadingContext, _globalOptions, this, textView, textBuffer, _suggestedActionCategoryRegistry)
-                : new SyncSuggestedActionsSource(_threadingContext, _globalOptions, this, textView, textBuffer, _suggestedActionCategoryRegistry);
+            return _globalOptions.GetOption(SuggestionsOptions.AsynchronousQuickActionsDisableFeatureFlag)
+                ? new SyncSuggestedActionsSource(_threadingContext, _globalOptions, this, textView, textBuffer, _suggestedActionCategoryRegistry)
+                : new AsyncSuggestedActionsSource(_threadingContext, _globalOptions, this, textView, textBuffer, _suggestedActionCategoryRegistry);
         }
     }
 }

src/EditorFeatures/Core/Implementation/Suggestions/SuggestionsOptions.cs

@@ -10,9 +10,6 @@ internal static class SuggestionsOptions
     {
         private const string FeatureName = "SuggestionsOptions";
 
-        public static readonly Option2<bool?> Asynchronous = new(FeatureName, nameof(Asynchronous), defaultValue: null,
-            new RoamingProfileStorageLocation("TextEditor.Specific.Suggestions.Asynchronous2"));
-
         public static readonly Option2<bool> AsynchronousQuickActionsDisableFeatureFlag = new(FeatureName, nameof(AsynchronousQuickActionsDisableFeatureFlag), defaultValue: false,
             new FeatureFlagStorageLocation("Roslyn.AsynchronousQuickActionsDisable"));
     }

src/EditorFeatures/Core/Implementation/Suggestions/SuggestionsOptionsProvider.cs

@@ -21,7 +21,6 @@ public SuggestionsOptionsProvider()
         }
 
         public ImmutableArray<IOption> Options { get; } = ImmutableArray.Create<IOption>(
-            SuggestionsOptions.Asynchronous,
             SuggestionsOptions.AsynchronousQuickActionsDisableFeatureFlag);
     }
 }

src/VisualStudio/CSharp/Impl/Options/AdvancedOptionPageControl.xaml

@@ -87,13 +87,6 @@
                               Content="{x:Static local:AdvancedOptionPageStrings.Option_Add_missing_using_directives_on_paste}" />
                 </StackPanel>
             </GroupBox>
-            <GroupBox x:Uid="QuickActionsBox"
-                      Header="{x:Static local:AdvancedOptionPageStrings.Option_Quick_Actions}">
-                <StackPanel>
-                    <CheckBox x:Name="ComputeQuickActionsAsynchronouslyExperimental"
-                              Content="{x:Static local:AdvancedOptionPageStrings.Option_Compute_Quick_Actions_asynchronously_experimental}" />
-                </StackPanel>
-            </GroupBox>
             <GroupBox x:Uid="HighlightingGroupBox"
                       Header="{x:Static local:AdvancedOptionPageStrings.Option_Highlighting}">
                 <StackPanel>

src/VisualStudio/CSharp/Impl/Options/AdvancedOptionPageControl.xaml.cs

@@ -93,13 +93,6 @@ public AdvancedOptionPageControl(OptionStore optionStore, IComponentModel compon
             BindToOption(ShowRemarksInQuickInfo, QuickInfoOptions.ShowRemarksInQuickInfo, LanguageNames.CSharp);
             BindToOption(DisplayLineSeparators, FeatureOnOffOptions.LineSeparator, LanguageNames.CSharp);
 
-            // Quick Actions
-            BindToOption(ComputeQuickActionsAsynchronouslyExperimental, SuggestionsOptions.Asynchronous, () =>
-            {
-                // If the option has not been set by the user, check if the option is disabled from experimentation.
-                return !optionStore.GetOption(SuggestionsOptions.AsynchronousQuickActionsDisableFeatureFlag);
-            });
-
             // Highlighting
             BindToOption(EnableHighlightReferences, FeatureOnOffOptions.ReferenceHighlighting, LanguageNames.CSharp);
             BindToOption(EnableHighlightKeywords, FeatureOnOffOptions.KeywordHighlighting, LanguageNames.CSharp);

src/VisualStudio/CSharp/Impl/Options/AdvancedOptionPageStrings.cs

@@ -177,12 +177,6 @@ public static string Option_OptimizeForSolutionSize_Regular
         public static string Option_OptimizeForSolutionSize_Small
             => CSharpVSResources.Small;
 
-        public static string Option_Quick_Actions
-            => ServicesVSResources.Quick_Actions;
-
-        public static string Option_Compute_Quick_Actions_asynchronously_experimental
-            => ServicesVSResources.Compute_Quick_Actions_asynchronously_experimental;
-
         public static string Option_Outlining
             => ServicesVSResources.Outlining;
 

src/VisualStudio/Core/Def/ServicesVSResources.resx

@@ -1802,12 +1802,6 @@ Additional information: {1}</value>
   <data name="Run_code_analysis_in_separate_process_requires_restart" xml:space="preserve">
     <value>Run code analysis in separate process (requires restart)</value>
   </data>
-  <data name="Compute_Quick_Actions_asynchronously_experimental" xml:space="preserve">
-    <value>Compute Quick Actions asynchronously (experimental, requires restart)</value>
-  </data>
-  <data name="Quick_Actions" xml:space="preserve">
-    <value>Quick Actions</value>
-  </data>
   <data name="Combine_inheritance_margin_with_indicator_margin" xml:space="preserve">
     <value>Combine inheritance margin with indicator margin</value>
   </data>