Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove user facing option around async-lightbulbs (17.1 and up only) #56858

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Remove user facing option around async-lightbulbs (17.1 and up only) #56858

merged 3 commits into from
Sep 30, 2021

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners September 29, 2021 20:02
@ghost ghost added the Needs UX Triage label Sep 29, 2021
@CyrusNajmabadi
Add new option so anyone who set the option value in 17.0 doesn't for…
0fe1a91 
…ever disable async lightbulbs in 17.1 and onwards
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski this will fix the issue in main, and should fix it once merged into main-vs-deps.

@Cosifne Cosifne mentioned this pull request Sep 29, 2021
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@runfoapp runfoapp bot mentioned this pull request Sep 29, 2021
Open
@CyrusNajmabadi CyrusNajmabadi merged commit 4fc7245 into dotnet:main Sep 30, 2021
@ghost ghost added this to the Next milestone Sep 30, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the enableAsyncLightbulbs17.1proper branch September 30, 2021 06:47
@RikkiGibson RikkiGibson modified the milestones: Next, 17.1.P1 Oct 25, 2021
CyrusNajmabadi added a commit to CyrusNajmabadi/roslyn that referenced this pull request Nov 17, 2021
@CyrusNajmabadi
Revert "Merge pull request dotnet#56858 from CyrusNajmabadi/enableAsy…
95223d1 
…ncLightbulbs17.1proper"

This reverts commit 4fc7245, reversing
changes made to 3ee34ed.
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@dibarbet dibarbet Awaiting requested review from dibarbet

@Cosifne Cosifne Awaiting requested review from Cosifne

Assignees
No one assigned
Labels
Area-IDE UX Review Not Required UX Review Not Required
Projects
None yet
Milestone
17.1.P1
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @jasonmalinowski @ryzngard @RikkiGibson