Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StackFrame Parser/Lexer as EmbeddedLanguage #56957
StackFrame Parser/Lexer as EmbeddedLanguage #56957
Changes from 1 commit
f560e75
872a90d
ba21c9e
9c04adb
c8b0bd3
6f8fcd4
541f3fa
a5c49bc
1a0252c
35099cc
59e54aa
7d6ab41
1830c57
b171e55
87964e6
15479df
b0e6e6e
0866c7b
3b4cbcb
09c7ba4
9b95418
9f28a29
b3bdfa1
ceac888
f972f11
dd729d2
ebabf0f
80c7b77
3904852
598571c
ad40dfa
1beb9dc
cba32de
ab1a662
eeefa48
3958af9
29754a2
1abd3ba
a017ec2
4a4b2eb
6f73bb6
875dc31
0401dc4
06f0a69
6654637
e74a7f1
99bf2bf
87ba143
9eaa65e
7dec0eb
73d38e4
07007cc
d283218
80e5fcc
604ec77
1fcea01
c358299
9ca8a9c
750a12a
eaeb334
62d4bad
a4013bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if you already did it, but:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the edge cases. think about empty tokens, or an extra intermediary token. so things like
A.B.(params)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as inputs to
TtestIdentifierNames
I tried to do this with various input into
TestInvalidInputs
. Let me know if you can think of explicit things I missed